Skip to content

fix!: send correct response code on exception #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2022
Merged

fix!: send correct response code on exception #427

merged 1 commit into from
Feb 15, 2022

Conversation

matthewrobertson
Copy link
Member

This commit updates the http response we send when the customer's function throws to:

  1. always send a 500 HTTP status
  2. strip the error message from the response body when running in production

anniefu
anniefu reviewed Feb 11, 2022
View reviewed changes
grant
grant approved these changes Feb 15, 2022
View reviewed changes
@matthewrobertson matthewrobertson force-pushed the error-messages branch 2 times, most recently from c5f8047 to 1b54b05 Compare February 15, 2022 17:56
@matthewrobertson matthewrobertson merged commit 5d996fe into master Feb 15, 2022
@release-please release-please bot mentioned this pull request Feb 15, 2022
Merged
@anniefu anniefu linked an issue Feb 24, 2022 that may be closed by this pull request
Handle thrown exceptions consistently with other frameworks #422
Closed
@anniefu anniefu mentioned this pull request Apr 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaylaNguyen KaylaNguyen Awaiting requested review from KaylaNguyen

2 more reviewers

@grant grant grant approved these changes

@anniefu anniefu anniefu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle thrown exceptions consistently with other frameworks
3 participants
@matthewrobertson @grant @anniefu