Skip to content

There are typos in a comment and a log message #11294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kamoljan opened this issue Mar 16, 2024 · 1 comment · Fixed by #11332
Closed

There are typos in a comment and a log message #11294

kamoljan opened this issue Mar 16, 2024 · 1 comment · Fixed by #11332
Assignees
@kweinmeister
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@kamoljan
Copy link

In which file did you encounter the issue?

https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/endpoints/getting-started/main.py

Did you change the file? If so, how?

git diff
diff --git a/endpoints/getting-started/main.py b/endpoints/getting-started/main.py
index 5e3077936..db386f1f2 100644
--- a/endpoints/getting-started/main.py
+++ b/endpoints/getting-started/main.py
@@ -53,7 +53,7 @@ def echo():

 # [START endpoints_auth_info_backend]
 def auth_info():
-    """Retrieves the authenication information from Google Cloud Endpoints."""
+    """Retrieves the authentication information from Google Cloud Endpoints."""
     encoded_info = request.headers.get("X-Endpoint-API-UserInfo", None)
     if encoded_info:
         info_json = _base64_decode(encoded_info)
@@ -89,7 +89,7 @@ def auth_info_firebase():
 @app.errorhandler(http_client.INTERNAL_SERVER_ERROR)
 def unexpected_error(e):
     """Handle exceptions by returning swagger-compliant json."""
-    logging.exception("An error occured while processing the request.")
+    logging.exception("An error occurred while processing the request.")
     response = jsonify(
         {"code": http_client.INTERNAL_SERVER_ERROR, "message": f"Exception: {e}"}
     )

Describe the issue

It is two typos in a comment and log message
@kamoljan kamoljan added priority: p2 Moderately-important priority. Fix may not be included in next release. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 16, 2024
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 16, 2024
@magar51
Copy link
Contributor

magar51 commented Mar 21, 2024

Please assign it to me

magar51 added a commit to magar51/python-docs-samples that referenced this issue Mar 21, 2024
@magar51
There are typos in a comment and a log message GoogleCloudPlatform#11294
dfbad1e
@magar51 magar51 mentioned this issue Mar 21, 2024
Merged
9 tasks
leahecole added a commit that referenced this issue Apr 23, 2024
@magar51 @leahecole
Outdated bash operator import on Composer 2 Docs #11433 (#11440)
768f82b 
* Update samples for google-cloud-speech to improve usability

* Update transcribe_streaming_v2.py

* Handling Issue #11248

Update samples for google-cloud-speech to improve usability

* There are typos in a comment and a log message #11294

* Outdated bash operator import on Composer 2 Docs #11433

* Update grouping.py

* Update grouping.py

Outdated bash operator import on Composer 2 Docs #11433

* Update grouping.py

* Update example_dag.py

* Apply suggestions from code review

reverting Airflow 1 changes where relevant

* Apply suggestions from code review

Removing changes made in #11332

* Apply suggestions from code review

revert speech code changes

* Update speech/snippets/transcribe_streaming_v2.py

* Update speech/snippets/transcribe_streaming_v2.py

---------

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
iennae pushed a commit that referenced this issue Jun 17, 2024
@magar51 @leahecole
There are typos in a comment and a log message #11294 (#11332)
85df924 
* Update samples for google-cloud-speech to improve usability

* Update transcribe_streaming_v2.py

* Handling Issue #11248

Update samples for google-cloud-speech to improve usability

* There are typos in a comment and a log message #11294

* Update speech/snippets/transcribe_streaming_v2.py

---------

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kweinmeister kweinmeister

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

There are typos in a comment and a log message #11294 magar51/python-docs-samples
3 participants
@kamoljan @kweinmeister @magar51