Skip to content

Add voice selection by name #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 11, 2020
Merged

Add voice selection by name #2687

merged 11 commits into from
Jan 11, 2020

Conversation

texasmichelle
Copy link
Member

Add name parameter based on user request.

b/143877133

@texasmichelle texasmichelle requested a review from a team as a code owner January 7, 2020 00:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2020
@busunkim96
Copy link
Contributor

It looks like 2.7 is failing because html doesn't exist in the standard library for Python 2.7 https://docs.python.org/3/library/html.html

______ ERROR collecting texttospeech/cloud-client/ssml_addresses_test.py _______
ImportError while importing test module '/tmpfs/src/github/python-docs-samples/texttospeech/cloud-client/ssml_addresses_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
ssml_addresses_test.py:15: in <module>
    from ssml_addresses import text_to_ssml
ssml_addresses.py:19: in <module>
    import html
E   ImportError: No module named html
- generated xml file: /tmpfs/src/github/python-docs-samples/texttospeech/cloud-client/sponge_log.xml -

@texasmichelle
Copy link
Member Author

If these tests are running repo-wide, would it make sense to add future to testing/requirements.txt instead?

@texasmichelle
Copy link
Member Author

Per @leahecole, best to keep future in this product area for now since the issue hasn't cropped up in other products and py2 will be disappearing eventually.

@texasmichelle texasmichelle merged commit 09bc50d into GoogleCloudPlatform:master Jan 11, 2020
@texasmichelle texasmichelle deleted the tts_b_143877133 branch January 11, 2020 00:49
busunkim96 pushed a commit to googleapis/python-texttospeech that referenced this pull request Apr 9, 2020
@texasmichelle @leahecole
Add voice selection by name [(#2687)](GoogleCloudPlatform/python-docs…
14c2108 
…-samples#2687)

* Add voice selection by name

* Add future to requirements.txt

Fixes python2 test failures referencing html.

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96 pushed a commit to googleapis/python-texttospeech that referenced this pull request May 13, 2020
@texasmichelle @leahecole
Add voice selection by name [(#2687)](GoogleCloudPlatform/python-docs…
bc51725 
…-samples#2687)

* Add voice selection by name

* Add future to requirements.txt

Fixes python2 test failures referencing html.

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96 pushed a commit to googleapis/python-texttospeech that referenced this pull request May 13, 2020
@texasmichelle @leahecole @busunkim96
Add voice selection by name [(#2687)](GoogleCloudPlatform/python-docs…
e84e022 
…-samples#2687)

* Add voice selection by name

* Add future to requirements.txt

Fixes python2 test failures referencing html.

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96 pushed a commit to googleapis/python-texttospeech that referenced this pull request May 13, 2020
@texasmichelle @leahecole @busunkim96
Add voice selection by name [(#2687)](GoogleCloudPlatform/python-docs…
409c34d 
…-samples#2687)

* Add voice selection by name

* Add future to requirements.txt

Fixes python2 test failures referencing html.

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96 pushed a commit to googleapis/python-texttospeech that referenced this pull request May 20, 2020
@texasmichelle @leahecole @busunkim96
Add voice selection by name [(#2687)](GoogleCloudPlatform/python-docs…
7d2324f 
…-samples#2687)

* Add voice selection by name

* Add future to requirements.txt

Fixes python2 test failures referencing html.

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96 pushed a commit to googleapis/python-texttospeech that referenced this pull request May 20, 2020
@texasmichelle @leahecole @busunkim96
Add voice selection by name [(#2687)](GoogleCloudPlatform/python-docs…
c401ac4 
…-samples#2687)

* Add voice selection by name

* Add future to requirements.txt

Fixes python2 test failures referencing html.

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
@msampathkumar msampathkumar mentioned this pull request Nov 10, 2022
Merged
8 tasks
msampathkumar pushed a commit that referenced this pull request Nov 10, 2022
@texasmichelle @leahecole @busunkim96
Add voice selection by name [(#2687)](#2687)
4a642ee 
* Add voice selection by name

* Add future to requirements.txt

Fixes python2 test failures referencing html.

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 22, 2023
@texasmichelle @leahecole @busunkim96
Add voice selection by name [(#2687)](GoogleCloudPlatform/python-docs…
e744f40 
…-samples#2687)

* Add voice selection by name

* Add future to requirements.txt

Fixes python2 test failures referencing html.

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 22, 2023
@texasmichelle @leahecole @busunkim96
Add voice selection by name [(#2687)](GoogleCloudPlatform/python-docs…
7ab33c9 
…-samples#2687)

* Add voice selection by name

* Add future to requirements.txt

Fixes python2 test failures referencing html.

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@crwilcox crwilcox

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@texasmichelle @busunkim96 @crwilcox @googlebot @leahecole