Skip to content

[dlp] inspect_content_test.py::test_inspect_datastore is potentially broken #3422

@tmatsuo

Description

@tmatsuo

The following tests are potentially broken:

dlp/inspect_content_test.py::test_inspect_datastore
dlp/inspect_content_test.py::test_inspect_datastore_no_results

Once merged, #3420 will fix the timeout issue on our builds.

#3420 also will make a change for the test behavior. Previously, these tests are trying to check if the callback function in the sample has been called as expected.

Previous assertion:

assert "Info type: EMAIL_ADDRESS" in out

Current assertion:

assert "Inspection operation started" in out

As far as I tried, the callback was never called even with timeout of 420 seconds. That's why the test is now only checking if the operation was successfully started.

It's great if we can do the following:

  1. debug why the callback is not called
  2. test if the callback is called again

@andrewsg Do you have any insight? I'm asking because you're the original author.

Metadata

Metadata

Assignees

Labels

api: dlpIssues related to the Sensitive Data Protection API.priority: p2Moderately-important priority. Fix may not be included in next release.testing

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions