Skip to content

[functions] debug disabled tests and re-enable them if possible #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tmatsuo opened this issue May 16, 2020 · 2 comments
Closed

[functions] debug disabled tests and re-enable them if possible #3775

tmatsuo opened this issue May 16, 2020 · 2 comments
Assignees
@ace-n
Labels
api: functions priority: p2 Moderately-important priority. Fix may not be included in next release. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tmatsuo
Copy link
Contributor

tmatsuo commented May 16, 2020 •
edited
Loading

The PR #3774 disabled some tests in functions directory.

  • pubsub/main_test.py
  • slack/main_test.py

Debug them and re-enable them if possible.

@ace-n Let me know if you can not fix this.
@tmatsuo tmatsuo added testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: functions labels May 16, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented May 16, 2020

For slack/main_test.py, I think only thing needed is to set an appropriate value for "SLACK_SECRET". I assume this value can be just calculated somehow so that it is not a really secret. With that assumption, I put a placeholder in noxfile_config.py for adding the value.

If the value is really a secret, you have to remove noxfile_config.py and add it to testing/secrets.tar.enc.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label May 17, 2020
@tmatsuo tmatsuo mentioned this issue May 18, 2020
Merged
@tmatsuo tmatsuo added the priority: p2 Moderately-important priority. Fix may not be included in next release. label May 18, 2020
@tmatsuo tmatsuo assigned ace-n and unassigned billyjacobson May 18, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label May 18, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented May 19, 2020

fixed by #3808

@tmatsuo tmatsuo closed this as completed May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ace-n ace-n

Labels
api: functions priority: p2 Moderately-important priority. Fix may not be included in next release. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tmatsuo @ace-n @billyjacobson @yoshi-automation