Skip to content

Use new nox #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

busunkim96
Copy link
Contributor

Closes #1736.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2018
@busunkim96
Copy link
Contributor Author

@engelke Would you be able to review this?

@engelke
Copy link
Contributor

engelke commented Oct 16, 2018 via email

@engelke engelke added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 16, 2018
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 16, 2018
@engelke engelke added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 16, 2018
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 16, 2018
@engelke
Copy link
Contributor

engelke commented Oct 16, 2018

Seems to be a problem with nox under Python 2.7, which Travis is using for lint. Here's the error message:

Traceback (most recent call last):
File "/home/travis/virtualenv/python2.7.14/bin/nox", line 7, in
from nox.main import main
File "/home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages/nox/main.py", line 155
print(dist.version, file=sys.stderr)
^
SyntaxError: invalid syntax

Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any remaining configuration issues need to be addressed after merge is in place.

@engelke
Copy link
Contributor

engelke commented Oct 18, 2018

Changes were moved to PR 1770 in order to add broader changes needed to pass Travis check.

@engelke engelke closed this Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants