Skip to content

Miscellaneous updates to copy composer environment script. #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2019
Merged

Miscellaneous updates to copy composer environment script. #1919

merged 4 commits into from
Jan 25, 2019

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Dec 8, 2018

  • Fail fast if required executables missing
  • Pass project to storage client
  • Set bucket permissions without subprocess
  • Handle fuse umount on mac os

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 8, 2018
@jmcarp
Miscellaneous updates to copy composer environment script.
6274006 
* Fail fast if required executables missing
* Pass project to storage client
* Set bucket permissions without subprocess
* Handle fuse umount on mac os
@jmcarp jmcarp force-pushed the copy-composer-fixes branch from e766187 to 6274006 Compare December 8, 2018 05:05
@jmcarp jmcarp mentioned this pull request Dec 8, 2018
Merged
@jmcarp
Copy link
Contributor Author

jmcarp commented Dec 8, 2018

cc @engelke

engelke
engelke approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Kokoro tests are not running regularly, and are failing for reasons unrelated to this PR.

@engelke engelke merged commit 528273f into GoogleCloudPlatform:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmcarp @engelke @googlebot