Skip to content

Add a list of allowed_client_ids to EchoApi.get_user_email. #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2019

Conversation

tomboc
Copy link
Contributor

@tomboc tomboc commented Feb 1, 2019

The use of an OAuth token issued by accounts.google.com triggers
a special path in Endpoints Framework, which validates if the
client id ('azp' claim of JWT token) is included in allowed_client_ids
list supplied to @endpoints.method decorator.

Without the change, sample client described at [1] receives 401
Unauthorized errors when attempting to access the API.

[1] https://cloud.google.com/endpoints/docs/frameworks/python/javascript-client

The use of an OAuth token issued by accounts.google.com triggers
a special path in Endpoints Framework, which validates if the
client id ('azp' claim of JWT token) is included in allowed_client_ids
list supplied to @endpoints.method decorator.

Without the change, sample client described at [1] receives 401
Unauthorized errors when attempting to access the API.

[1] https://cloud.google.com/endpoints/docs/frameworks/python/javascript-client
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2019
Copy link
Member

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast merged commit 35e8cab into GoogleCloudPlatform:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants