From fc14e9d796fb8143d00baffda31cfba4e2f99c54 Mon Sep 17 00:00:00 2001 From: Sarath Kaul Date: Wed, 15 Jan 2020 12:20:42 +0530 Subject: [PATCH 1/5] Http Task Tests updated for Task Name --- tasks/create_http_task_test.py | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tasks/create_http_task_test.py b/tasks/create_http_task_test.py index b1e50cc82de..2e82314e806 100644 --- a/tasks/create_http_task_test.py +++ b/tasks/create_http_task_test.py @@ -16,13 +16,19 @@ import create_http_task -TEST_PROJECT_ID = os.getenv('GCLOUD_PROJECT') -TEST_LOCATION = os.getenv('TEST_QUEUE_LOCATION', 'us-central1') -TEST_QUEUE_NAME = os.getenv('TEST_QUEUE_NAME', 'my-queue') +TEST_PROJECT_ID = os.getenv("GCLOUD_PROJECT") +TEST_LOCATION = os.getenv("TEST_QUEUE_LOCATION", "us-central1") +TEST_QUEUE_NAME = os.getenv("TEST_QUEUE_NAME", "my-queue") +TEST_TASK_NAME = os.getenv("TEST_TASK_NAME", "my-task") def test_create_http_task(): - url = 'https://example.com/task_handler' + url = "https://example.com/task_handler" result = create_http_task.create_http_task( - TEST_PROJECT_ID, TEST_QUEUE_NAME, TEST_LOCATION, url) + project=TEST_PROJECT_ID, + queue=TEST_QUEUE_NAME, + location=TEST_LOCATION, + url=url, + task_name=TEST_TASK_NAME, + ) assert TEST_QUEUE_NAME in result.name From feab26c9f529437f86463bdcbb842dde8278a77d Mon Sep 17 00:00:00 2001 From: Sarath Kaul Date: Thu, 16 Jan 2020 10:11:03 +0530 Subject: [PATCH 2/5] Changes --- tasks/create_http_task_test.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tasks/create_http_task_test.py b/tasks/create_http_task_test.py index 2e82314e806..b196ce26591 100644 --- a/tasks/create_http_task_test.py +++ b/tasks/create_http_task_test.py @@ -31,4 +31,5 @@ def test_create_http_task(): url=url, task_name=TEST_TASK_NAME, ) + assert TEST_QUEUE_NAME in result.name From e966d5a5e811feb66cace0202e2d25ca6f1bbb99 Mon Sep 17 00:00:00 2001 From: Sarath Kaul Date: Thu, 16 Jan 2020 10:13:49 +0530 Subject: [PATCH 3/5] Changes Reverted --- tasks/create_http_task_test.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tasks/create_http_task_test.py b/tasks/create_http_task_test.py index b196ce26591..2e82314e806 100644 --- a/tasks/create_http_task_test.py +++ b/tasks/create_http_task_test.py @@ -31,5 +31,4 @@ def test_create_http_task(): url=url, task_name=TEST_TASK_NAME, ) - assert TEST_QUEUE_NAME in result.name From ce55299ede2afd9b9679f14e995bec261fbc229a Mon Sep 17 00:00:00 2001 From: Sarath Kaul Date: Thu, 16 Jan 2020 10:25:05 +0530 Subject: [PATCH 4/5] Task Name Test Changes --- tasks/create_http_task_test.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tasks/create_http_task_test.py b/tasks/create_http_task_test.py index 2e82314e806..b196ce26591 100644 --- a/tasks/create_http_task_test.py +++ b/tasks/create_http_task_test.py @@ -31,4 +31,5 @@ def test_create_http_task(): url=url, task_name=TEST_TASK_NAME, ) + assert TEST_QUEUE_NAME in result.name From e2a978cd14f41c3cdd3178a564bc3e5807448c34 Mon Sep 17 00:00:00 2001 From: Sarath Kaul Date: Thu, 16 Jan 2020 10:41:12 +0530 Subject: [PATCH 5/5] Changes Reverted --- tasks/create_http_task_test.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tasks/create_http_task_test.py b/tasks/create_http_task_test.py index b196ce26591..2e82314e806 100644 --- a/tasks/create_http_task_test.py +++ b/tasks/create_http_task_test.py @@ -31,5 +31,4 @@ def test_create_http_task(): url=url, task_name=TEST_TASK_NAME, ) - assert TEST_QUEUE_NAME in result.name