Skip to content

testing: replace @flaky with @pytest.mark.flaky #3496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 25, 2020
Merged

testing: replace @flaky with @pytest.mark.flaky #3496

merged 4 commits into from
Apr 25, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Apr 24, 2020

No description provided.

@tmatsuo tmatsuo requested a review from leahecole April 24, 2020 01:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Apr 24, 2020

Flake filed: #3548

Restarting the build

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Apr 24, 2020

This is a good PR for finding flakes ;)

@tmatsuo tmatsuo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
gguuss
gguuss approved these changes Apr 25, 2020
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmatsuo tmatsuo merged commit bfcc58b into GoogleCloudPlatform:master Apr 25, 2020
@tmatsuo tmatsuo deleted the flaky branch April 25, 2020 00:02
@telpirion telpirion mentioned this pull request Nov 16, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@michaelawyu michaelawyu Awaiting requested review from michaelawyu

@nnegrey nnegrey Awaiting requested review from nnegrey

@sirtorry sirtorry Awaiting requested review from sirtorry

@telpirion telpirion Awaiting requested review from telpirion

+1 more reviewer

@gguuss gguuss gguuss approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@gguuss gguuss

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tmatsuo @gguuss @leahecole @googlebot @kokoro-team