grpc samples: specify type on --sample_rate to prevent TypeError #513

zackse · 2016-09-09T21:31:50Z

The --sample_rate argument in speech/grpc/transcribe.py and speech/grpc/transcribe_async.py did not specify a type, which meant the value would be treated as a string, resulting in an exception during protobuf conversion:

$ python transcribe.py --encoding FLAC --sample_rate 16000 gs://path/to/my.flac
Traceback (most recent call last):
  File "transcribe.py", line 95, in <module>
    main(args.input_uri, args.encoding, args.sample_rate)
  File "transcribe.py", line 66, in main
    language_code='en-US',  # a BCP-47 language tag
  File "/Users/zackse/code/python/contrib/python-docs-samples/speech/api-client/env/lib/python2.7/site-packages/google/protobuf/internal/python_message.py", line 535, in init
    _ReraiseTypeErrorWithFieldName(message_descriptor.name, field_name)
  File "/Users/zackse/code/python/contrib/python-docs-samples/speech/api-client/env/lib/python2.7/site-packages/google/protobuf/internal/python_message.py", line 455, in _ReraiseTypeErrorWithFieldName
    six.reraise(type(exc), exc, sys.exc_info()[2])
  File "/Users/zackse/code/python/contrib/python-docs-samples/speech/api-client/env/lib/python2.7/site-packages/google/protobuf/internal/python_message.py", line 533, in init
    setattr(self, field_name, field_value)
  File "/Users/zackse/code/python/contrib/python-docs-samples/speech/api-client/env/lib/python2.7/site-packages/google/protobuf/internal/python_message.py", line 669, in field_setter
    new_value = type_checker.CheckValue(new_value)
  File "/Users/zackse/code/python/contrib/python-docs-samples/speech/api-client/env/lib/python2.7/site-packages/google/protobuf/internal/type_checkers.py", line 132, in CheckValue
    raise TypeError(message)
TypeError: '16000' has type <type 'str'>, but expected one of: (<type 'int'>, <type 'long'>) for field RecognitionConfig.sample_rate

Hope this helps. Thanks for this service and the samples!

googlebot · 2016-09-09T21:31:52Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

zackse · 2016-09-09T21:33:39Z

I signed the CLA.

googlebot · 2016-09-09T21:33:40Z

CLAs look good, thanks!

puneith · 2016-09-11T15:57:24Z

@zackse LGTM. Thanks for your contribution!

specify type on --sample_rate to prevent TypeError

dc47f75

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 9, 2016

theacodes assigned jerjou Sep 9, 2016

theacodes added the ML label Sep 9, 2016

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 9, 2016

puneith self-assigned this Sep 11, 2016

jerjou merged commit 4c7741d into GoogleCloudPlatform:master Sep 12, 2016

telpirion mentioned this pull request Jan 18, 2023

chore(dialogflow): migrate code from googleapis/python-dialogflow #9011

Closed

8 tasks

telpirion pushed a commit that referenced this pull request Jan 18, 2023

chore(deps): update dependency pytest to v7.1.2 (#513)

8645abc

yil532 mentioned this pull request Feb 1, 2023

chore(dialogflow): migrate code from googleapis/python-dialogflow #9078

Merged

8 tasks

dandhlee pushed a commit that referenced this pull request Feb 6, 2023

chore(deps): update dependency pytest to v7.1.2 (#513)

4909d50

telpirion pushed a commit that referenced this pull request Mar 13, 2023

chore(deps): update dependency pytest to v7.1.2 (#513)

e7d3e6a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

grpc samples: specify type on --sample_rate to prevent TypeError #513

grpc samples: specify type on --sample_rate to prevent TypeError #513

zackse commented Sep 9, 2016 •

edited

Loading

googlebot commented Sep 9, 2016

zackse commented Sep 9, 2016

googlebot commented Sep 9, 2016

puneith commented Sep 11, 2016

grpc samples: specify type on --sample_rate to prevent TypeError #513

grpc samples: specify type on --sample_rate to prevent TypeError #513

Conversation

zackse commented Sep 9, 2016 • edited Loading

googlebot commented Sep 9, 2016

zackse commented Sep 9, 2016

googlebot commented Sep 9, 2016

puneith commented Sep 11, 2016

zackse commented Sep 9, 2016 •

edited

Loading