Skip to content

sqlcipher 4.8.0 #221742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

sqlcipher 4.8.0 #221742

wants to merge 1 commit into from

Conversation

BrewTestBot
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

release notes 
- Fixes regression in `PRAGMA cipher_migrate` where an error would be thrown when migrating a current-version database
- Adds selective locking in critical sections of the library for shared cache connections (Note: use of shared cache is still strongly discouraged)
- Standardizes initial private heap size to 48KB to ensure mlock under constrained limits
- Removes changes to windows working set sizes
- Improvements to logging of memory stats and other cleanup

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Apr 28, 2025
@daeho-ro daeho-ro force-pushed the bump-sqlcipher-4.8.0 branch 3 times, most recently from b4d0d84 to 4a17742 Compare April 28, 2025 16:10
@chenrui333
Copy link
Member 

   ==> make install
  + /usr/bin/install -d /opt/homebrew/Cellar/sqlcipher/4.8.0/lib/pkgconfig
  + /usr/bin/install -d /opt/homebrew/Cellar/sqlcipher/4.8.0/lib
  install: mkdir /opt/homebrew/Cellar/sqlcipher/4.8.0/lib: File exists
  make: *** [/opt/homebrew/Cellar/sqlcipher/4.8.0/lib] Error 71

@daeho-ro
Copy link
Member

daeho-ro commented Apr 29, 2025 •
edited
Loading

Maybe their binary name change is a problem. Should we avoid sqlite3?

The library...

4.8.0
├── bin
│   └── sqlite3
├── CHANGELOG.md
├── include
│   ├── sqlite3.h
│   └── sqlite3ext.h
├── INSTALL_RECEIPT.json
├── lib
│   ├── libsqlite3.0.dylib ⇒ libsqlite3.3.49.1.dylib
│   ├── libsqlite3.3.49.1.dylib
│   ├── libsqlite3.a
│   ├── libsqlite3.dylib ⇒ libsqlite3.3.49.1.dylib
│   └── pkgconfig
│       └── sqlite3.pc
├── LICENSE.md
├── LICENSE.txt
├── README.md
├── sbom.spdx.json
└── share
    └── man
        └── man1
            └── sqlite3.1

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 29, 2025
@daeho-ro daeho-ro force-pushed the bump-sqlcipher-4.8.0 branch from 1f6602f to d6ec35d Compare April 29, 2025 13:56
@daeho-ro
Copy link
Member

daeho-ro commented Apr 29, 2025 •
edited
Loading

This is a different package but have same library name with sqlite3. Is this ok?

keg only maybe fine, but need review.

@daeho-ro daeho-ro added help wanted Task(s) needing PRs from the community or maintainers ready to merge PR can be merged once CI is green and removed help wanted Task(s) needing PRs from the community or maintainers labels Apr 30, 2025
@daeho-ro daeho-ro force-pushed the bump-sqlcipher-4.8.0 branch from d6ec35d to 7a1ab02 Compare May 5, 2025 11:25
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label May 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label May 7, 2025
@daeho-ro daeho-ro removed the stale No recent activity label May 8, 2025
@chenrui333
Copy link
Member

Maybe their binary name change is a problem. Should we avoid sqlite3?

The library...

4.8.0
├── bin
│   └── sqlite3
├── CHANGELOG.md
├── include
│   ├── sqlite3.h
│   └── sqlite3ext.h
├── INSTALL_RECEIPT.json
├── lib
│   ├── libsqlite3.0.dylib ⇒ libsqlite3.3.49.1.dylib
│   ├── libsqlite3.3.49.1.dylib
│   ├── libsqlite3.a
│   ├── libsqlite3.dylib ⇒ libsqlite3.3.49.1.dylib
│   └── pkgconfig
│       └── sqlite3.pc
├── LICENSE.md
├── LICENSE.txt
├── README.md
├── sbom.spdx.json
└── share
    └── man
        └── man1
            └── sqlite3.1

any options of turning off sqlite3 creation? (if it is same sqlite3, might be good to depend on sqlite formula) cc @Homebrew/core

@daeho-ro
Copy link
Member

This formula itself is sqlite3 with additional function, not just depend. They have renamed their binary, library from sqlcipher to sqlite3

@daeho-ro daeho-ro removed the ready to merge PR can be merged once CI is green label May 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label May 13, 2025
@github-actions github-actions bot closed this May 15, 2025
@github-actions github-actions bot deleted the bump-sqlcipher-4.8.0 branch May 15, 2025 11:24
@chenrui333
Copy link
Member

  • BREAKING CHANGE: Renames default executable and library build outputs from sqlcipher and libsqlcipher to sqlite3 and libsqlite3 (for alignment with SQLite)

Yeah, I feel like we can just add a conflict and move forward with the build

chenrui333
chenrui333 reviewed May 15, 2025
View reviewed changes
Formula/s/sqlcipher.rb
Comment on lines 45 to +47
-DSQLITE_ENABLE_COLUMN_METADATA
-DSQLITE_EXTRA_INIT=sqlcipher_extra_init
-DSQLITE_EXTRA_SHUTDOWN=sqlcipher_extra_shutdown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also adding -DSQLCIPHER_CRYPTO_OPENSSL?

Copy link
Member

@daeho-ro daeho-ro May 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a default value.

https://github.com/sqlcipher/sqlcipher/blob/c7e811b399379c948b423872ad7ba91d2ce38434/src/sqlcipher.c#L88-L94

chenrui333
chenrui333 reviewed May 15, 2025
View reviewed changes
Formula/s/sqlcipher.rb
Comment on lines +50 to +51
args << "LDFLAGS=-lcrypto"
args << "LDFLAGS=-lcrypto -lm" if OS.linux?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just

    args << "LDFLAGS=-lcrypto"
    args << "-lm" if OS.linux?

@chenrui333
Copy link
Member

#223614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

@daeho-ro daeho-ro daeho-ro left review comments

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` stale No recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrewTestBot @chenrui333 @daeho-ro