fix (hmr): Better way to know if the HMR is reloaded. See nativescript-vue#388

msaelices · msaelices · commit ad9e0072fd1e · 2019-03-04T00:52:18.000+01:00
diff --git a/platform/nativescript/runtime/components/frame.js b/platform/nativescript/runtime/components/frame.js
@@ -1,5 +1,5 @@
 import { setFrame, getFrame, deleteFrame } from '../../util/frame'
-import { isHMRChecking } from '../../util/hmr'
+import { isHMRChecking, resetHMRChecking } from '../../util/hmr'
 import { isAndroid, isIOS } from 'tns-core-modules/platform'
 import { ios as iosUtils } from 'tns-core-modules/utils/utils'
 
@@ -161,6 +161,7 @@ export default {
       } else {
         // TODO: Implement for Android
       }
+      resetHMRChecking()
     },
 
     navigate(entry, back = false) {
diff --git a/platform/nativescript/util/hmr.js b/platform/nativescript/util/hmr.js
@@ -12,10 +12,6 @@ if (module.hot) {
   module.hot.addStatusHandler(status => {
     if (status === 'check') {
       hmrChecking = true
-      // TODO: Improve the logic here
-      setTimeout(() => {
-        hmrChecking = false
-      }, 2000)
     }
   })
 }

Original file line number	Diff line number	Diff line change
`@@ -12,10 +12,6 @@ if (module.hot) {`
`12`	`12`	`module.hot.addStatusHandler(status => {`
`13`	`13`	`if (status === 'check') {`
`14`	`14`	`hmrChecking = true`
`15`		`- // TODO: Improve the logic here`
`16`		`- setTimeout(() => {`
`17`		`- hmrChecking = false`
`18`		`- }, 2000)`
`19`	`15`	`}`
`20`	`16`	`})`
`21`	`17`	`}`