Skip to content

Commit 3880d03

Browse files
committed
add test and lint
1 parent 37a7f3b commit 3880d03

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

s3transfer/crt.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -901,7 +901,7 @@ def _default_get_make_request_args(
901901
algorithm=AwsSigningAlgorithm.V4_ASYMMETRIC,
902902
region="*",
903903
use_double_uri_encode=False,
904-
should_normalize_uri_path=False
904+
should_normalize_uri_path=False,
905905
)
906906
call_args.bucket = accesspoint_arn_details['resource_name']
907907
elif is_s3express_bucket(call_args.bucket):
@@ -910,7 +910,7 @@ def _default_get_make_request_args(
910910
make_request_args['signing_config'] = AwsSigningConfig(
911911
algorithm=AwsSigningAlgorithm.V4_S3EXPRESS,
912912
use_double_uri_encode=False,
913-
should_normalize_uri_path=False
913+
should_normalize_uri_path=False,
914914
)
915915
return make_request_args
916916

tests/functional/test_crt.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,12 @@ def _assert_expected_s3express_request(
163163
make_request_kwargs['signing_config'].algorithm,
164164
awscrt.auth.AwsSigningAlgorithm.V4_S3EXPRESS,
165165
)
166+
self.assertFalse(
167+
make_request_kwargs['signing_config'].use_double_uri_encode,
168+
)
169+
self.assertFalse(
170+
make_request_kwargs['signing_config'].should_normalize_uri_path,
171+
)
166172

167173
def _assert_expected_mrap_request(
168174
self, make_request_kwargs, expected_http_method='GET'
@@ -179,6 +185,12 @@ def _assert_expected_mrap_request(
179185
awscrt.auth.AwsSigningAlgorithm.V4_ASYMMETRIC,
180186
)
181187
self.assertEqual(make_request_kwargs['signing_config'].region, "*")
188+
self.assertFalse(
189+
make_request_kwargs['signing_config'].use_double_uri_encode,
190+
)
191+
self.assertFalse(
192+
make_request_kwargs['signing_config'].should_normalize_uri_path,
193+
)
182194

183195
def _assert_subscribers_called(self, expected_future=None):
184196
self.assertTrue(self.record_subscriber.on_queued_called)

0 commit comments

Comments
 (0)