Avoid buffer overread when compressing messageset in KafkaProducer

dpkp · dpkp · commit d179a3f62e7d · 2016-07-17T12:08:57.000-07:00
diff --git a/kafka/producer/buffer.py b/kafka/producer/buffer.py
@@ -103,8 +103,9 @@ def close(self):
         if not self._closed:
             if self._compressor:
                 # TODO: avoid copies with bytearray / memoryview
+                uncompressed_size = self._buffer.tell()
                 self._buffer.seek(4)
-                msg = Message(self._compressor(self._buffer.read()),
+                msg = Message(self._compressor(self._buffer.read(uncompressed_size - 4)),
                               attributes=self._compression_attributes,
                               magic=self._message_version)
                 encoded = msg.encode()
