chore: enable object-shorthand (typescript-eslint#9816)

abrahamguo · Josh-Cena · web-flow · commit 1c2938fbb794 · 2024-08-19T14:56:41.000-04:00
enable object-shorthand

Co-authored-by: Joshua Chen &lt;sidachen2003@gmail.com&gt;
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -216,6 +216,7 @@ export default tseslint.config(
       'no-useless-concat': 'error',
       'no-var': 'error',
       'no-void': ['error', { allowAsStatement: true }],
+      'object-shorthand': 'error',
       'one-var': ['error', 'never'],
       'operator-assignment': 'error',
       'prefer-arrow-callback': 'error',
diff --git a/packages/eslint-plugin/src/rules/index.ts b/packages/eslint-plugin/src/rules/index.ts
@@ -251,7 +251,7 @@ export default {
   'strict-boolean-expressions': strictBooleanExpressions,
   'switch-exhaustiveness-check': switchExhaustivenessCheck,
   'triple-slash-reference': tripleSlashReference,
-  typedef: typedef,
+  typedef,
   'unbound-method': unboundMethod,
   'unified-signatures': unifiedSignatures,
   'use-unknown-in-catch-callback-variable': useUnknownInCatchCallbackVariable,
diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-boolean-literal-compare.ts b/packages/eslint-plugin/src/rules/no-unnecessary-boolean-literal-compare.ts
@@ -216,7 +216,7 @@ export default createRule<Options, MessageIds>({
         }
 
         context.report({
-          fix: function* (fixer) {
+          *fix(fixer) {
             // 1. isUnaryNegation - parent negation
             // 2. literalBooleanInComparison - is compared to literal boolean
             // 3. negated - is expression negated
diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-qualifier.ts b/packages/eslint-plugin/src/rules/no-unnecessary-qualifier.ts
@@ -176,7 +176,7 @@ export default createRule({
       TSQualifiedName(node: TSESTree.TSQualifiedName): void {
         visitNamespaceAccess(node, node.left, node.right);
       },
-      'MemberExpression[computed=false]': function (
+      'MemberExpression[computed=false]'(
         node: TSESTree.MemberExpression,
       ): void {
         const property = node.property as TSESTree.Identifier;
diff --git a/packages/eslint-plugin/src/rules/no-unsafe-assignment.ts b/packages/eslint-plugin/src/rules/no-unsafe-assignment.ts
@@ -401,7 +401,7 @@ export default createRule({
         const restType = services.getTypeAtLocation(node.argument);
         if (isTypeAnyType(restType) || isTypeAnyArrayType(restType, checker)) {
           context.report({
-            node: node,
+            node,
             messageId: 'unsafeArraySpread',
             data: createData(restType),
           });
diff --git a/packages/eslint-plugin/src/rules/no-unsafe-call.ts b/packages/eslint-plugin/src/rules/no-unsafe-call.ts
@@ -69,7 +69,7 @@ export default createRule<[], MessageIds>({
 
         context.report({
           node: reportingNode,
-          messageId: messageId,
+          messageId,
           data: {
             type: isErrorType ? '`error` type' : '`any`',
           },
diff --git a/packages/eslint-plugin/tests/rules/naming-convention/cases/createTestCases.ts b/packages/eslint-plugin/tests/rules/naming-convention/cases/createTestCases.ts
@@ -285,7 +285,7 @@ export function createTestCases(cases: Cases): void {
               code: `// ${JSON.stringify(options)}\n${test.code
                 .map(code => code.replaceAll(REPLACE_REGEX, preparedName))
                 .join('\n')}`,
-              errors: errors,
+              errors,
             };
           };
 
diff --git a/packages/rule-tester/src/utils/validationHelpers.ts b/packages/rule-tester/src/utils/validationHelpers.ts
@@ -113,7 +113,7 @@ export function wrapParser(
     }
 
     simpleTraverse(ast, {
-      visitorKeys: visitorKeys,
+      visitorKeys,
       enter: node => defineStartEndAsError('node', node),
     });
     ast.tokens?.forEach(token => defineStartEndAsError('token', token));
diff --git a/packages/typescript-estree/src/convert.ts b/packages/typescript-estree/src/convert.ts
@@ -2357,7 +2357,7 @@ export class Converter {
         return this.createNode<TSESTree.BigIntLiteral>(node, {
           type: AST_NODE_TYPES.Literal,
           raw: rawValue,
-          value: value,
+          value,
           bigint: value == null ? bigint : String(value),
           range,
         });
@@ -2896,7 +2896,7 @@ export class Converter {
                 node,
               )
             : null,
-          range: range,
+          range,
         });
 
         if (node.isTypeOf) {
@@ -3044,7 +3044,7 @@ export class Converter {
 
               name = this.createNode<TSESTree.TSQualifiedName>(nextName, {
                 left: name,
-                right: right,
+                right,
                 range: [name.range[0], right.range[1]],
                 type: AST_NODE_TYPES.TSQualifiedName,
               });
diff --git a/packages/typescript-estree/src/parseSettings/createParseSettings.ts b/packages/typescript-estree/src/parseSettings/createParseSettings.ts
@@ -163,7 +163,7 @@ export function createParseSettings(
       project: getProjectConfigFiles(parseSettings, tsestreeOptions.project),
       projectFolderIgnoreList: tsestreeOptions.projectFolderIgnoreList,
       singleRun: parseSettings.singleRun,
-      tsconfigRootDir: tsconfigRootDir,
+      tsconfigRootDir,
     });
   }
 
diff --git a/packages/website-eslint/src/mock/assert.js b/packages/website-eslint/src/mock/assert.js
@@ -67,11 +67,11 @@ class AssertionError extends Error {
 
 function fail(actual, expected, message, operator, stackStartFunction) {
   throw new AssertionError({
-    message: message,
-    actual: actual,
-    expected: expected,
-    operator: operator,
-    stackStartFunction: stackStartFunction,
+    message,
+    actual,
+    expected,
+    operator,
+    stackStartFunction,
   });
 }
 
diff --git a/packages/website-eslint/src/mock/path.js b/packages/website-eslint/src/mock/path.js
@@ -212,16 +212,16 @@ export function extname(path) {
 }
 
 export default {
-  extname: extname,
-  basename: basename,
-  dirname: dirname,
-  sep: sep,
-  delimiter: delimiter,
-  relative: relative,
-  join: join,
-  isAbsolute: isAbsolute,
-  normalize: normalize,
-  resolve: resolve,
+  extname,
+  basename,
+  dirname,
+  sep,
+  delimiter,
+  relative,
+  join,
+  isAbsolute,
+  normalize,
+  resolve,
 };
 
 function filter(xs, f) {
diff --git a/packages/website/sidebars/sidebar.rules.js b/packages/website/sidebars/sidebar.rules.js
@@ -3,7 +3,7 @@ const plugin = require('@typescript-eslint/eslint-plugin');
 
 const rules = Object.entries(plugin.rules).map(([name, rule]) => {
   return {
-    name: name,
+    name,
     meta: { ...rule.meta },
   };
 });
diff --git a/packages/website/src/components/ast/DataRenderer.tsx b/packages/website/src/components/ast/DataRenderer.tsx
@@ -143,7 +143,7 @@ function JsonObject(
   const computed = useMemo(() => {
     const nodeType = getNodeType(props.value);
     return {
-      nodeType: nodeType,
+      nodeType,
       typeName: getTypeName(props.value, nodeType),
       value: Object.entries(props.value).filter(item =>
         filterProperties(item[0], item[1], nodeType, props.showTokens),
diff --git a/packages/website/src/components/lib/jsonSchema.ts b/packages/website/src/components/lib/jsonSchema.ts
@@ -125,7 +125,7 @@ export function getEslintJsonSchema(
       },
       rules: {
         type: 'object',
-        properties: properties,
+        properties,
         additionalProperties: false,
       },
     },
@@ -206,7 +206,7 @@ export function getTypescriptJsonSchema(): JSONSchema4 {
     properties: {
       compilerOptions: {
         type: 'object',
-        properties: properties,
+        properties,
       },
     },
   };
diff --git a/packages/website/src/components/linter/createLinter.ts b/packages/website/src/components/linter/createLinter.ts
@@ -66,7 +66,7 @@ export function createLinter(
 
   linter.getRules().forEach((item, name) => {
     rules.set(name, {
-      name: name,
+      name,
       description: item.meta?.docs?.description,
       url: item.meta?.docs?.url,
       schema: item.meta?.schema ?? [],
@@ -104,7 +104,7 @@ export function createLinter(
     const code = system.readFile(filename);
     if (code) {
       return linter.verifyAndFix(code, eslintConfig, {
-        filename: filename,
+        filename,
         fix: true,
       });
     }
diff --git a/packages/website/src/components/linter/createParser.ts b/packages/website/src/components/linter/createParser.ts
@@ -57,9 +57,9 @@ export function createParser(
 
       const parseSettings: ParseSettings = {
         ...defaultParseSettings,
-        code: code,
+        code,
         codeFullText: code,
-        filePath: filePath,
+        filePath,
       };
 
       const program = compilerHost.languageService.getProgram();
diff --git a/packages/website/src/components/linter/utils.ts b/packages/website/src/components/linter/utils.ts
@@ -95,7 +95,7 @@ export function parseMarkers(
 
     // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
     result[group] ||= {
-      group: group,
+      group,
       uri: code.target,
       items: [],
     };

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ export default createRule<Options, MessageIds>({`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`context.report({`
`219`		`- fix: function* (fixer) {`
	`219`	`+ *fix(fixer) {`
`220`	`220`	`// 1. isUnaryNegation - parent negation`
`221`	`221`	`// 2. literalBooleanInComparison - is compared to literal boolean`
`222`	`222`	`// 3. negated - is expression negated`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ export function wrapParser(`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`simpleTraverse(ast, {`
`116`		`- visitorKeys: visitorKeys,`
	`116`	`+ visitorKeys,`
`117`	`117`	`enter: node => defineStartEndAsError('node', node),`
`118`	`118`	`});`
`119`	`119`	`ast.tokens?.forEach(token => defineStartEndAsError('token', token));`
Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ export function createParseSettings(`
`163`	`163`	`project: getProjectConfigFiles(parseSettings, tsestreeOptions.project),`
`164`	`164`	`projectFolderIgnoreList: tsestreeOptions.projectFolderIgnoreList,`
`165`	`165`	`singleRun: parseSettings.singleRun,`
`166`		`- tsconfigRootDir: tsconfigRootDir,`
	`166`	`+ tsconfigRootDir,`
`167`	`167`	`});`
`168`	`168`	`}`
`169`	`169`