chore: update to nx 18 (typescript-eslint#8442)

JamesHenry · web-flow · commit 28b94625e58d · 2024-02-13T01:26:29.000+04:00
diff --git a/package.json b/package.json
@@ -62,9 +62,9 @@
     "@babel/types": "^7.23.3",
     "@eslint/eslintrc": "^2.1.4",
     "@eslint/js": "^8.56.0",
-    "@nx/eslint": "17.3.1",
-    "@nx/jest": "17.3.1",
-    "@nx/workspace": "17.3.1",
+    "@nx/eslint": "18.0.4",
+    "@nx/jest": "18.0.4",
+    "@nx/workspace": "18.0.4",
     "@swc/core": "^1.4.0",
     "@swc/jest": "^0.2.26",
     "@types/babel__code-frame": "^7.0.3",
@@ -110,7 +110,7 @@
     "markdownlint-cli": "^0.39.0",
     "ncp": "^2.0.0",
     "netlify": "^13.1.9",
-    "nx": "17.3.1",
+    "nx": "18.0.4",
     "prettier": "3.2.5",
     "pretty-format": "^29.6.2",
     "raw-loader": "^4.0.2",
diff --git a/packages/repo-tools/package.json b/packages/repo-tools/package.json
@@ -12,7 +12,7 @@
     "generate-lib": "tsx ./src/generate-lib.mts",
     "lint": "npx nx lint",
     "postinstall-script": "tsx ./src/postinstall.mts",
-    "test": "jest --coverage",
+    "test": "npx jest --coverage",
     "typecheck": "tsc -p tsconfig.json --noEmit"
   },
   "devDependencies": {
diff --git a/packages/rule-schema-to-typescript-types/package.json b/packages/rule-schema-to-typescript-types/package.json
@@ -29,7 +29,7 @@
     "generate-sponsors": "tsx ./src/generate-sponsors.ts",
     "lint": "npx nx lint",
     "postinstall-script": "tsx ./src/postinstall.ts",
-    "test": "jest --coverage",
+    "test": "npx jest --coverage",
     "typecheck": "tsc -p tsconfig.json --noEmit"
   },
   "dependencies": {
diff --git a/packages/rule-tester/package.json b/packages/rule-tester/package.json
@@ -42,7 +42,7 @@
     "lint": "npx nx lint",
     "pretest-eslint-base": "tsc -b tsconfig.build.json",
     "test-eslint-base": "mocha --require source-map-support/register ./tests/eslint-base/eslint-base.test.js",
-    "test": "jest --coverage",
+    "test": "npx jest --coverage",
     "typecheck": "tsc -p tsconfig.json --noEmit"
   },
   "//": "NOTE - AJV is out-of-date, but it's intentionally synced with ESLint - https://github.com/eslint/eslint/blob/ad9dd6a933fd098a0d99c6a9aa059850535c23ee/package.json#L70",
diff --git a/tools/release/release.mts b/tools/release/release.mts
@@ -1,9 +1,5 @@
 import { execaSync } from 'execa';
-import {
-  releaseChangelog,
-  releasePublish,
-  releaseVersion,
-} from 'nx/src/command-line/release';
+import { releaseChangelog, releasePublish, releaseVersion } from 'nx/release';
 import yargs from 'yargs';
 
 const options = await yargs(process.argv.slice(2))
@@ -46,12 +42,16 @@ if (!options.dryRun) {
 }
 
 // This will create a release on GitHub
-await releaseChangelog({
+const changelogStatus = await releaseChangelog({
   versionData: projectsVersionData,
   version: workspaceVersion,
   dryRun: options.dryRun,
   verbose: options.verbose,
 });
+if (changelogStatus !== 0) {
+  console.error('🚨 Failed to generate changelog');
+  process.exit(changelogStatus);
+}
 
 // An explicit null value here means that no changes were detected across any package
 // eslint-disable-next-line eqeqeq
@@ -60,8 +60,9 @@ if (workspaceVersion === null) {
     '⏭️ No changes detected across any package, skipping publish step altogether',
   );
 } else {
-  await releasePublish({
+  const publishStatus = await releasePublish({
     dryRun: options.dryRun,
     verbose: options.verbose,
   });
+  process.exit(publishStatus);
 }
diff --git a/yarn.lock b/yarn.lock
