Do not parse as JSON when window has a truthy 'json' prop

FagnerMartinsBrack · FagnerMartinsBrack · commit bccdaf79f7be · 2016-08-04T20:03:28.000+10:00
Closes js-cookiegh-250. Closes js-cookiegh-238.
diff --git a/src/js.cookie.js b/src/js.cookie.js
@@ -127,7 +127,7 @@
 
 		api.set = api;
 		api.get = function (key) {
-			return api(key);
+			return api.call(api, key);
 		};
 		api.getJSON = function () {
 			return api.apply({
diff --git a/test/tests.js b/test/tests.js
@@ -125,6 +125,19 @@ QUnit.test('Call to read cookie when passing an Object Literal as the second arg
 	assert.strictEqual(document.cookie, '', 'should not create a cookie');
 });
 
+// github.com/js-cookie/js-cookie/issues/238
+QUnit.test('Call to read cookie when there is a window.json variable globally', function (assert) {
+	assert.expect(1);
+	window.json = true;
+	Cookies.set('boolean', true);
+	assert.strictEqual(typeof Cookies.get('boolean'), 'string', 'should not change the returned type');
+	// IE 6-8 throw an exception if trying to delete a window property
+	// See stackoverflow.com/questions/1073414/deleting-a-window-property-in-ie/1824228
+	try {
+		delete window.json;
+	} catch (e) {}
+});
+
 QUnit.module('write', lifecycle);
 
 QUnit.test('String primitive', function (assert) {
