Merge pull request webpack#6155 from EugeneHlushko/feature/disallow-load-initial-on-demand

sokra · web-flow · commit 069789a2e7e5 · 2017-12-20T10:49:20.000+01:00
Feature: Disallow to load initial chunk on demand via throwing an error
diff --git a/lib/AsyncDependencyToInitialChunkError.js b/lib/AsyncDependencyToInitialChunkError.js
@@ -6,11 +6,11 @@
 
 const WebpackError = require("./WebpackError");
 
-module.exports = class AsyncDependencyToInitialChunkWarning extends WebpackError {
+module.exports = class AsyncDependencyToInitialChunkError extends WebpackError {
 	constructor(chunkName, module, loc) {
 		super();
 
-		this.name = "AsyncDependencyToInitialChunkWarning";
+		this.name = "AsyncDependencyToInitialChunkError";
 		this.message = `It's not allowed to load an initial chunk on demand. The chunk name "${chunkName}" is already used by an entrypoint.`;
 		this.module = module;
 		this.origin = module;
diff --git a/lib/Compilation.js b/lib/Compilation.js
@@ -24,7 +24,7 @@ const ModuleTemplate = require("./ModuleTemplate");
 const RuntimeTemplate = require("./RuntimeTemplate");
 const Dependency = require("./Dependency");
 const ChunkRenderError = require("./ChunkRenderError");
-const AsyncDependencyToInitialChunkWarning = require("./AsyncDependencyToInitialChunkWarning");
+const AsyncDependencyToInitialChunkError = require("./AsyncDependencyToInitialChunkError");
 const CachedSource = require("webpack-sources").CachedSource;
 const Stats = require("./Stats");
 const Semaphore = require("./util/Semaphore");
@@ -1031,8 +1031,7 @@ class Compilation extends Tapable {
 			if(c === undefined) {
 				c = this.namedChunks[b.chunkName];
 				if(c && c.isInitial()) {
-					// TODO webpack 4: convert this to an error
-					this.warnings.push(new AsyncDependencyToInitialChunkWarning(b.chunkName, b.module, b.loc));
+					this.errors.push(new AsyncDependencyToInitialChunkError(b.chunkName, b.module, b.loc));
 					c = chunk;
 				} else {
 					c = this.addChunk(b.chunkName, b.module, b.loc);
diff --git a/test/cases/chunks/weird-reference-to-entry/errors.js b/test/cases/chunks/weird-reference-to-entry/errors.js
