Skip to content

Commit 09bf8f5

Browse files
quantizorquantizor
committed
refactor: adjustments per PR comments
1 parent 1f29fa9 commit 09bf8f5

File tree

2 files changed

+17
-15
lines changed

2 files changed

+17
-15
lines changed

‎lib/CachePlugin.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,11 @@ class CachePlugin {
5959
});
6060
}, err => {
6161
if(err) return callback(err);
62-
Array.from(fileTs.keys()).forEach(key => {
63-
fileTs.set(key, fileTs.get(key) + this.FS_ACCURENCY);
64-
});
62+
63+
for(const [file, ts] of fileTs) {
64+
fileTs.set(file, ts + this.FS_ACCURENCY);
65+
}
66+
6567
callback();
6668
});
6769
});

‎test/NodeWatchFileSystem.unittest.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ describe("NodeWatchFileSystem", function() {
6868
if(err) throw err;
6969
filesModified.should.be.eql([fileDirect]);
7070
dirsModified.should.be.eql([]);
71-
fileTimestamps.get(fileDirect).should.have.type("number");
71+
(typeof fileTimestamps.get(fileDirect)).should.be.eql("number");
7272
watcher.close();
7373
done();
7474
});
@@ -87,7 +87,7 @@ describe("NodeWatchFileSystem", function() {
8787
if(err) throw err;
8888
filesModified.should.be.eql([fileDirect]);
8989
dirsModified.should.be.eql([]);
90-
fileTimestamps.get(fileDirect).should.have.type("number");
90+
(typeof fileTimestamps.get(fileDirect)).should.be.eql("number");
9191
watcher.close();
9292
done();
9393
});
@@ -104,7 +104,7 @@ describe("NodeWatchFileSystem", function() {
104104
if(err) throw err;
105105
filesModified.should.be.eql([]);
106106
dirsModified.should.be.eql([fixtures]);
107-
dirTimestamps.get(fixtures).should.have.type("number");
107+
(typeof dirTimestamps.get(fixtures)).should.be.eql("number");
108108
watcher.close();
109109
done();
110110
});
@@ -123,7 +123,7 @@ describe("NodeWatchFileSystem", function() {
123123
if(err) throw err;
124124
filesModified.should.be.eql([]);
125125
dirsModified.should.be.eql([fixtures]);
126-
dirTimestamps.get(fixtures).should.have.type("number");
126+
(typeof dirTimestamps.get(fixtures)).should.be.eql("number");
127127
watcher.close();
128128
done();
129129
});
@@ -140,7 +140,7 @@ describe("NodeWatchFileSystem", function() {
140140
if(err) throw err;
141141
filesModified.should.be.eql([]);
142142
dirsModified.should.be.eql([fixtures]);
143-
dirTimestamps.get(fixtures).should.have.type("number");
143+
(typeof dirTimestamps.get(fixtures)).should.be.eql("number");
144144
watcher.close();
145145
done();
146146
});
@@ -159,7 +159,7 @@ describe("NodeWatchFileSystem", function() {
159159
if(err) throw err;
160160
filesModified.should.be.eql([]);
161161
dirsModified.should.be.eql([fixtures]);
162-
dirTimestamps.get(fixtures).should.have.type("number");
162+
(typeof dirTimestamps.get(fixtures)).should.be.eql("number");
163163
watcher.close();
164164
done();
165165
});
@@ -177,9 +177,9 @@ describe("NodeWatchFileSystem", function() {
177177
if(err) throw err;
178178
filesModified.should.be.eql([fileSubdir, fileDirect]);
179179
dirsModified.should.be.eql([fixtures]);
180-
fileTimestamps.get(fileDirect).should.have.type("number");
181-
fileTimestamps.get(fileSubdir).should.have.type("number");
182-
dirTimestamps.get(fixtures).should.have.type("number");
180+
(typeof fileTimestamps.get(fileDirect)).should.be.eql("number");
181+
(typeof fileTimestamps.get(fileSubdir)).should.be.eql("number");
182+
(typeof dirTimestamps.get(fixtures)).should.be.eql("number");
183183
watcher.close();
184184
done();
185185
});
@@ -197,9 +197,9 @@ describe("NodeWatchFileSystem", function() {
197197
if(err) throw err;
198198
filesModified.should.be.eql([fileSubdir, fileDirect]);
199199
dirsModified.should.be.eql([fixtures]);
200-
fileTimestamps.get(fileDirect).should.have.type("number");
201-
fileTimestamps.get(fileSubdir).should.have.type("number");
202-
dirTimestamps.get(fixtures).should.have.type("number");
200+
(typeof fileTimestamps.get(fileDirect)).should.be.eql("number");
201+
(typeof fileTimestamps.get(fileSubdir)).should.be.eql("number");
202+
(typeof dirTimestamps.get(fixtures)).should.be.eql("number");
203203
watcher.close();
204204
done();
205205
});

0 commit comments

Comments
 (0)