Merge pull request webpack#7471 from webpack/fix/7470

sokra · web-flow · commit 2491f5ddf2c1 · 2018-06-04T13:08:52.000+02:00
Add a test case about nodeEnv
diff --git a/lib/WebpackOptionsDefaulter.js b/lib/WebpackOptionsDefaulter.js
@@ -294,11 +294,10 @@ class WebpackOptionsDefaulter extends OptionsDefaulter {
 				}
 			}
 		]);
-		this.set(
-			"optimization.nodeEnv",
-			"make",
-			options => options.mode || "production"
-		);
+		this.set("optimization.nodeEnv", "make", options => {
+			// TODO: In webpack 5, it should return `false` when mode is `none`
+			return options.mode || "production";
+		});
 
 		this.set("resolve", "call", value => Object.assign({}, value));
 		this.set("resolve.unsafeCache", true);
diff --git a/test/configCases/issues/issue-7470/index.js b/test/configCases/issues/issue-7470/index.js
@@ -0,0 +1,3 @@
+it("should set NODE_ENV according to mode", () => {
+	expect(process.env.NODE_ENV).toBe(__MODE__);
+});
diff --git a/test/configCases/issues/issue-7470/webpack.config.js b/test/configCases/issues/issue-7470/webpack.config.js
@@ -0,0 +1,21 @@
+"use strict";
+
+const DefinePlugin = require("../../../../lib/DefinePlugin");
+
+module.exports = [
+	{
+		name: "development",
+		mode: "development",
+		plugins: [new DefinePlugin({ __MODE__: `"development"` })]
+	},
+	{
+		name: "production",
+		mode: "production",
+		plugins: [new DefinePlugin({ __MODE__: `"production"` })]
+	},
+	{
+		name: "none",
+		mode: "none",
+		plugins: [new DefinePlugin({ __MODE__: `"none"` })]
+	}
+];

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+it("should set NODE_ENV according to mode", () => {`
	`2`	`+ expect(process.env.NODE_ENV).toBe(__MODE__);`
	`3`	`+});`