Skip to content

Commit 57c6c43

Browse files
author
Jason Milloff
committed
Add requested changes from PR comments
1 parent fc0b327 commit 57c6c43

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

lib/WebpackOptionsDefaulter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ class WebpackOptionsDefaulter extends OptionsDefaulter {
129129
});
130130
this.set("output.devtoolNamespace", "make", options => {
131131
if (Array.isArray(options.output.library))
132-
return [].concat(options.output.library).join(".");
132+
return options.output.library.join(".");
133133
return options.output.library || "";
134134
});
135135
this.set("output.libraryTarget", "var");
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
it("should compile successfully when output.library is an array of strings", function() {});
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
module.exports = {
2+
devtool: "source-map",
3+
output: {
4+
filename: "MyLibrary.[name].js",
5+
library: ["Foo", "[name]"]
6+
}
7+
};

0 commit comments

Comments
 (0)