Skip to content

Commit 5cef13e

Browse files
committed
fixes
1 parent ce978bc commit 5cef13e

File tree

5 files changed

+14
-23
lines changed

5 files changed

+14
-23
lines changed

lib/HotModuleReplacementPlugin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ module.exports = class HotModuleReplacementPlugin {
163163

164164
const needChunkLoadingCode = chunk => {
165165
for(const chunkGroup of chunk.groupsIterable) {
166-
if(chunkGroup.chunks.length > 0) return true;
166+
if(chunkGroup.chunks.length > 1) return true;
167167
if(chunkGroup.getNumberOfChildren() > 0) return true;
168168
}
169169
return false;

lib/web/JsonpMainTemplatePlugin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class JsonpMainTemplatePlugin {
1818
};
1919
const needChunkLoadingCode = chunk => {
2020
for(const chunkGroup of chunk.groupsIterable) {
21-
if(chunkGroup.chunks.length > 0) return true;
21+
if(chunkGroup.chunks.length > 1) return true;
2222
if(chunkGroup.getNumberOfChildren() > 0) return true;
2323
}
2424
return false;

test/hotCases/hash/separate-css-file/file.css

Lines changed: 0 additions & 3 deletions
This file was deleted.

test/hotCases/hash/separate-css-file/index.js

Lines changed: 0 additions & 10 deletions
This file was deleted.

test/hotCases/runtime/dispose-removed-chunk/index.js

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,19 @@
11
it("should dispose a chunk which is removed from bundle", function(done) {
22
var m1 = require("./module");
3-
NEXT(require("../../update")(done, true, function() {
4-
var m2 = require("./module");
3+
m1.default.then((x1) => {
54
NEXT(require("../../update")(done, true, function() {
6-
var m3 = require("./module");
7-
Promise.all([m1.default, m2.default, m3.default]).then(function(arr) {
8-
arr[0].should.be.not.eql(arr[2]);
9-
done();
10-
});
5+
var m2 = require("./module");
6+
m2.default.then((x2) => {
7+
NEXT(require("../../update")(done, true, function() {
8+
var m3 = require("./module");
9+
m3.default.then((x3) => {
10+
x1.should.be.not.eql(x2);
11+
done();
12+
}).catch(done);
13+
}));
14+
}).catch(done);
1115
}));
12-
}));
16+
}).catch(done);
1317
});
1418

1519
if(module.hot) {

0 commit comments

Comments
 (0)