Merge pull request webpack#6291 from Iwouldliketobeapig/next

sokra · web-flow · commit 6437964207d5 · 2018-01-12T10:57:42.000+01:00
feat: CommonsChunkPlugin indexOf -&gt; includes
diff --git a/lib/optimize/CommonsChunkPlugin.js b/lib/optimize/CommonsChunkPlugin.js
@@ -257,7 +257,7 @@ Take a look at the "name"/"names" or async/children option.`);
 		if(Array.isArray(selectedChunks)) {
 			return allChunks.filter(chunk => {
 				const notCommmonChunk = chunk !== targetChunk;
-				const isSelectedChunk = selectedChunks.indexOf(chunk.name) > -1;
+				const isSelectedChunk = selectedChunks.includes(chunk.name);
 				return notCommmonChunk && isSelectedChunk;
 			});
 		}
@@ -386,7 +386,7 @@ Take a look at the "name"/"names" or async/children option.`);
 		for(const chunk of chunks) {
 			if(chunk === targetChunk) continue;
 			for(const block of chunk.blocksIterable) {
-				if(block.chunks.indexOf(targetChunk) === -1) {
+				if(!block.chunks.includes(targetChunk)) {
 					block.chunks.unshift(targetChunk);
 				}
 				targetChunk.addBlock(block);
