Options: default performance to false if not the web/webworker target(webpack#6715)

mc-zone · mc-zone · commit 7c0c1a089ee3 · 2018-03-12T21:16:01.000+08:00
diff --git a/lib/WebpackOptionsDefaulter.js b/lib/WebpackOptionsDefaulter.js
@@ -13,6 +13,10 @@ const isProductionLikeMode = options => {
 	return options.mode === "production" || !options.mode;
 };
 
+const isWebLikeTarget = options => {
+	return options.target === "web" || options.target === "webworker";
+};
+
 class WebpackOptionsDefaulter extends OptionsDefaulter {
 	constructor() {
 		super();
@@ -166,25 +170,16 @@ class WebpackOptionsDefaulter extends OptionsDefaulter {
 		this.set("node.__filename", "mock");
 		this.set("node.__dirname", "mock");
 
-		this.set(
-			"performance",
-			"make",
-			options => (isProductionLikeMode(options) ? false : undefined)
-		);
-		this.set("performance", "call", value => {
-			if (typeof value === "boolean") {
-				return value;
+		this.set("performance", "make", options => {
+			if (isWebLikeTarget(options) && isProductionLikeMode(options)) {
+				return {};
 			} else {
-				return Object.assign({}, value);
+				return false;
 			}
 		});
 		this.set("performance.maxAssetSize", 250000);
 		this.set("performance.maxEntrypointSize", 250000);
-		this.set(
-			"performance.hints",
-			"make",
-			options => (isProductionLikeMode(options) ? "warning" : false)
-		);
+		this.set("performance.hints", "warning");
 
 		this.set("optimization.removeAvailableModules", true);
 		this.set("optimization.removeEmptyChunks", true);
