Skip to content

Commit 8d36df1

Browse files
authored
Merge pull request webpack#7307 from webpack/bot/document-on-merge
Improve pull request template and add automatic issue to docs
2 parents e449143 + a8a42b4 commit 8d36df1

File tree

2 files changed

+56
-10
lines changed

2 files changed

+56
-10
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->
2+
<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->
3+
<!-- Try to link to an open issue for more information. -->
4+
5+
6+
<!-- In addition to that please answer these questions: -->
27

38
**What kind of change does this PR introduce?**
49

@@ -8,17 +13,11 @@
813

914
<!-- Note that we won't merge your changes if you don't add tests -->
1015

11-
**If relevant, link to documentation update:**
12-
13-
<!-- Link PR from webpack/webpack.js.org here, or N/A -->
14-
15-
**Summary**
16-
17-
<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->
18-
<!-- Try to link to an open issue for more information. -->
19-
2016
**Does this PR introduce a breaking change?**
2117

2218
<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->
2319

24-
**Other information**
20+
**What needs to be documented once your changes are merged?**
21+
22+
<!-- List all the information that needs to be added to the documentation after merge -->
23+
<!-- When your changes are merged you will be asked to contribute this to the documentation -->

open-bot.yaml

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -517,6 +517,53 @@ rules:
517517
If you think this is still a valid issue, please file a new issue with additional information.
518518
519519
520+
# Add action actions box to each pull request
521+
- filters:
522+
pull_request: true
523+
open: true
524+
not:
525+
comment:
526+
matching: admin-actions
527+
author: webpack-bot
528+
actions:
529+
comment:
530+
identifier: admin-actions
531+
message: |-
532+
*For maintainers only:*
533+
534+
* [x] <!-- document --> This need to be documented (issue in webpack/webpack.js.org will be filed when merged)
535+
536+
537+
# When a pull request need to be documented, create an issue in webpack/webpack.js.org when merged
538+
- filters:
539+
pull_request:
540+
merged: true
541+
comment:
542+
author: webpack-bot
543+
matching: "\\* \\[x\\] <!-- document -->"
544+
not:
545+
comment_1:
546+
author: webpack-bot
547+
matching: admin-action-document-executed
548+
actions:
549+
new_issue:
550+
target: webpack/webpack.js.org
551+
title: "Document webpack change: {{{pull_request.title}}}"
552+
body: |-
553+
<!-- documentation request from webpack/webpack -->
554+
555+
*A pull request by @{{pull_request.user.login}} was merged and maintainers requested a documentation change.*
556+
557+
See pull request: {{{pull_request.html_url}}}
558+
559+
---
560+
561+
{{{pull_request.body}}}
562+
comment:
563+
identifier: admin-action-document-executed
564+
message: |-
565+
I've created an issue to document this in webpack/webpack.js.org.
566+
520567
521568
522569

0 commit comments

Comments
 (0)