fixup test and error

sokra · sokra · commit 9528aa5cbdad · 2018-06-04T11:18:32.000+02:00
diff --git a/lib/dependencies/ImportParserPlugin.js b/lib/dependencies/ImportParserPlugin.js
@@ -266,8 +266,8 @@ class CommentCompilationWarning extends WebpackError {
 
 		this.name = "CommentCompilationWarning";
 
-		this.origin = this.module = module;
-		this.originLoc = loc;
+		this.module = module;
+		this.loc = loc;
 
 		Error.captureStackTrace(this, this.constructor);
 	}
diff --git a/test/__snapshots__/StatsTestCases.test.js.snap b/test/__snapshots__/StatsTestCases.test.js.snap
@@ -1008,16 +1008,25 @@ Entrypoint entry = entry.js
 `;
 
 exports[`StatsTestCases should print correct stats for import-with-invalid-options-comments 1`] = `
-"   6 modules
-
-WARNING in ./chunk.js
+"Built at: Thu Jan 01 1970 00:00:00 GMT
+[0] ./chunk-a.js 27 bytes {2} [built]
+[1] ./chunk-b.js 27 bytes {3} [built]
+[2] ./chunk-c.js 27 bytes {4} [built]
+[3] ./chunk-d.js 27 bytes {5} [built]
+[4] ./chunk.js 401 bytes {0} [built] [3 warnings]
+[5] ./index.js 50 bytes {1} [built]
+
+WARNING in ./chunk.js 4:11-77
 Compilation error while processing magic comment(-s): /* webpack Prefetch: 0, webpackChunkName: \\"notGoingToCompile-c\\" */: Unexpected identifier
+ @ ./index.js 1:0-49
 
-WARNING in ./chunk.js
+WARNING in ./chunk.js 5:11-38
 Compilation error while processing magic comment(-s): /* webpackPrefetch: nope */: nope is not defined
+ @ ./index.js 1:0-49
 
-WARNING in ./chunk.js
-Compilation error while processing magic comment(-s): /* webpackPrefetch: true, webpackChunkName: notGoingToCompileChunkName */: notGoingToCompileChunkName is not defined"
+WARNING in ./chunk.js 2:11-84
+Compilation error while processing magic comment(-s): /* webpackPrefetch: true, webpackChunkName: notGoingToCompileChunkName */: notGoingToCompileChunkName is not defined
+ @ ./index.js 1:0-49"
 `;
 
 exports[`StatsTestCases should print correct stats for limit-chunk-count-plugin 1`] = `
diff --git a/test/statsCases/import-with-invalid-options-comments/webpack.config.js b/test/statsCases/import-with-invalid-options-comments/webpack.config.js
@@ -4,5 +4,12 @@ module.exports = {
 	output: {
 		chunkFilename: "[name].js"
 	},
-	stats: "minimal"
+	stats: {
+		timings: false,
+		hash: false,
+		entrypoints: false,
+		assets: false,
+		errorDetails: true,
+		moduleTrace: true
+	}
 };

Original file line number	Diff line number	Diff line change
`@@ -266,8 +266,8 @@ class CommentCompilationWarning extends WebpackError {`
`266`	`266`
`267`	`267`	`this.name = "CommentCompilationWarning";`
`268`	`268`
`269`		`- this.origin = this.module = module;`
`270`		`- this.originLoc = loc;`
	`269`	`+ this.module = module;`
	`270`	`+ this.loc = loc;`
`271`	`271`
`272`	`272`	`Error.captureStackTrace(this, this.constructor);`
`273`	`273`	`}`