Merge pull request webpack#7586 from samccone/sjs/fix_webpack_profiling_race

sokra · web-flow · commit bb38c5d03970 · 2018-06-24T10:43:12.000+02:00
Fix race condition in profiling plugin.
diff --git a/lib/debug/ProfilingPlugin.js b/lib/debug/ProfilingPlugin.js
@@ -130,7 +130,14 @@ function createTrace(outputPath) {
 		trace,
 		counter,
 		profiler,
-		end: callback => fsStream.end(callback)
+		end: callback => {
+			// Wait until the write stream finishes.
+			fsStream.on("finish", () => {
+				callback();
+			});
+			// Tear down the readable trace stream.
+			trace.destroy();
+		}
 	};
 }
 
