Merge pull request webpack#7284 from Connormiha/optimize-remove-empty-chunks

sokra · web-flow · commit c39c9639783a · 2018-05-13T09:55:42.000+02:00
Optimize RemoveEmptyChunksPlugin
diff --git a/lib/optimize/RemoveEmptyChunksPlugin.js b/lib/optimize/RemoveEmptyChunksPlugin.js
@@ -8,15 +8,17 @@ class RemoveEmptyChunksPlugin {
 	apply(compiler) {
 		compiler.hooks.compilation.tap("RemoveEmptyChunksPlugin", compilation => {
 			const handler = chunks => {
-				chunks
-					.filter(
-						chunk =>
-							chunk.isEmpty() && !chunk.hasRuntime() && !chunk.hasEntryModule()
-					)
-					.forEach(chunk => {
+				for (let i = chunks.length - 1; i >= 0; i--) {
+					const chunk = chunks[i];
+					if (
+						chunk.isEmpty() &&
+						!chunk.hasRuntime() &&
+						!chunk.hasEntryModule()
+					) {
 						chunk.remove("empty");
-						chunks.splice(chunks.indexOf(chunk), 1);
-					});
+						chunks.splice(i, 1);
+					}
+				}
 			};
 			compilation.hooks.optimizeChunksBasic.tap(
 				"RemoveEmptyChunksPlugin",
