Skip to content

Commit f32bd41

Browse files
sokrasokra
committed
fix linting
1 parent 5238159 commit f32bd41

18 files changed

+40
-36
lines changed

‎lib/Chunk.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,8 @@ class Chunk {
162162
if (this._modules.size < otherChunk._modules.size) return 1;
163163
const a = this._modules[Symbol.iterator]();
164164
const b = otherChunk._modules[Symbol.iterator]();
165+
// eslint-disable-next-line
165166
while (true) {
166-
// eslint-disable-line
167167
const aItem = a.next();
168168
const bItem = b.next();
169169
if (aItem.done) return 0;

‎lib/HotModuleReplacement.runtime.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ module.exports = function() {
1212
var hotCurrentParents = []; // eslint-disable-line no-unused-vars
1313
var hotCurrentParentsTemp = []; // eslint-disable-line no-unused-vars
1414

15+
// eslint-disable-next-line no-unused-vars
1516
function hotCreateRequire(moduleId) {
16-
// eslint-disable-line no-unused-vars
1717
var me = installedModules[moduleId];
1818
if (!me) return $require$;
1919
var fn = function(request) {
@@ -80,8 +80,8 @@ module.exports = function() {
8080
return fn;
8181
}
8282

83+
// eslint-disable-next-line no-unused-vars
8384
function hotCreateModule(moduleId) {
84-
// eslint-disable-line no-unused-vars
8585
var hot = {
8686
// private stuff
8787
_acceptedDependencies: {},
@@ -206,8 +206,8 @@ module.exports = function() {
206206
});
207207
}
208208

209+
// eslint-disable-next-line no-unused-vars
209210
function hotAddUpdateChunk(chunkId, moreModules) {
210-
// eslint-disable-line no-unused-vars
211211
if (!hotAvailableFilesMap[chunkId] || !hotRequestedFilesMap[chunkId])
212212
return;
213213
hotRequestedFilesMap[chunkId] = false;

‎lib/Module.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,8 @@ class Module extends DependenciesBlock {
163163
otherModule._chunks.sortWith(sortByDebugId);
164164
const a = this._chunks[Symbol.iterator]();
165165
const b = otherModule._chunks[Symbol.iterator]();
166+
// eslint-disable-next-line no-constant-condition
166167
while (true) {
167-
// eslint-disable-line
168168
const aItem = a.next();
169169
const bItem = b.next();
170170
if (aItem.done) return true;

‎lib/MultiCompiler.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ module.exports = class MultiCompiler extends Tapable {
3434
for (const compiler of this.compilers) {
3535
let compilerDone = false;
3636
const compilerIndex = index++;
37+
// eslint-disable-next-line no-loop-func
3738
compiler.hooks.done.tap("MultiCompiler", stats => {
38-
// eslint-disable-line no-loop-func
3939
if (!compilerDone) {
4040
compilerDone = true;
4141
doneCompilers++;
@@ -45,8 +45,8 @@ module.exports = class MultiCompiler extends Tapable {
4545
this.hooks.done.call(new MultiStats(compilerStats));
4646
}
4747
});
48+
// eslint-disable-next-line no-loop-func
4849
compiler.hooks.invalid.tap("MultiCompiler", () => {
49-
// eslint-disable-line no-loop-func
5050
if (compilerDone) {
5151
compilerDone = false;
5252
doneCompilers--;

‎lib/Parser.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2055,7 +2055,9 @@ class Parser extends Tapable {
20552055
try {
20562056
ast = acorn.parse(code, parserOptions);
20572057
threw = false;
2058-
} catch (e) {}
2058+
} catch (e) {
2059+
threw = true;
2060+
}
20592061
}
20602062

20612063
if (threw) {

‎lib/Stats.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ class Stats {
9797
if (typeof item === "string") {
9898
const regExp = new RegExp(
9999
`[\\\\/]${item.replace(
100-
/[\-\[\]\/\{\}\(\)\*\+\?\.\\\^\$\|]/g,
100+
/[-[\]{}()*+?.\\^$|]/g,
101101
"\\$&"
102102
)}([\\\\/]|$|!|\\?)`
103103
); // eslint-disable-line no-useless-escape

‎lib/node/NodeMainTemplate.runtime.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44
*/
55
/*global installedChunks $hotChunkFilename$ hotAddUpdateChunk $hotMainFilename$ */
66
module.exports = function() {
7+
// eslint-disable-next-line no-unused-vars
78
function hotDownloadUpdateChunk(chunkId) {
8-
// eslint-disable-line no-unused-vars
99
var chunk = require("./" + $hotChunkFilename$);
1010
hotAddUpdateChunk(chunk.id, chunk.modules);
1111
}
1212

13+
// eslint-disable-next-line no-unused-vars
1314
function hotDownloadManifest() {
14-
// eslint-disable-line no-unused-vars
1515
try {
1616
var update = require("./" + $hotMainFilename$);
1717
} catch (e) {
@@ -20,8 +20,8 @@ module.exports = function() {
2020
return Promise.resolve(update);
2121
}
2222

23+
//eslint-disable-next-line no-unused-vars
2324
function hotDisposeChunk(chunkId) {
24-
//eslint-disable-line no-unused-vars
2525
delete installedChunks[chunkId];
2626
}
2727
};

‎lib/node/NodeMainTemplateAsync.runtime.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
*/
55
/*global installedChunks $hotChunkFilename$ $require$ hotAddUpdateChunk $hotMainFilename$ */
66
module.exports = function() {
7+
// eslint-disable-next-line no-unused-vars
78
function hotDownloadUpdateChunk(chunkId) {
8-
// eslint-disable-line no-unused-vars
99
var filename = require("path").join(__dirname, $hotChunkFilename$);
1010
require("fs").readFile(filename, "utf-8", function(err, content) {
1111
if (err) {
@@ -21,8 +21,8 @@ module.exports = function() {
2121
});
2222
}
2323

24+
// eslint-disable-next-line no-unused-vars
2425
function hotDownloadManifest() {
25-
// eslint-disable-line no-unused-vars
2626
var filename = require("path").join(__dirname, $hotMainFilename$);
2727
return new Promise(function(resolve, reject) {
2828
require("fs").readFile(filename, "utf-8", function(err, content) {
@@ -37,8 +37,8 @@ module.exports = function() {
3737
});
3838
}
3939

40+
//eslint-disable-next-line no-unused-vars
4041
function hotDisposeChunk(chunkId) {
41-
//eslint-disable-line no-unused-vars
4242
delete installedChunks[chunkId];
4343
}
4444
};

‎lib/optimize/AggressiveSplittingPlugin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,8 @@ class AggressiveSplittingPlugin {
158158
modulesB.sort();
159159
const aI = modulesA[Symbol.iterator]();
160160
const bI = modulesB[Symbol.iterator]();
161+
// eslint-disable-next-line no-constant-condition
161162
while (true) {
162-
// eslint-disable-line
163163
const aItem = aI.next();
164164
const bItem = bI.next();
165165
if (aItem.done) return 0;

‎lib/optimize/SplitChunksPlugin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ const compareEntries = (a, b) => {
6666
modulesB.sort();
6767
const aI = modulesA[Symbol.iterator]();
6868
const bI = modulesB[Symbol.iterator]();
69+
// eslint-disable-next-line no-constant-condition
6970
while (true) {
70-
// eslint-disable-line
7171
const aItem = aI.next();
7272
const bItem = bI.next();
7373
if (aItem.done) return 0;

‎lib/web/JsonpMainTemplate.runtime.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44
*/
55
/*globals hotAddUpdateChunk parentHotUpdateCallback document XMLHttpRequest $require$ $hotChunkFilename$ $hotMainFilename$ $crossOriginLoading$ */
66
module.exports = function() {
7+
// eslint-disable-next-line no-unused-vars
78
function webpackHotUpdateCallback(chunkId, moreModules) {
8-
// eslint-disable-line no-unused-vars
99
hotAddUpdateChunk(chunkId, moreModules);
1010
if (parentHotUpdateCallback) parentHotUpdateCallback(chunkId, moreModules);
1111
} //$semicolon
1212

13+
// eslint-disable-next-line no-unused-vars
1314
function hotDownloadUpdateChunk(chunkId) {
14-
// eslint-disable-line no-unused-vars
1515
var head = document.getElementsByTagName("head")[0];
1616
var script = document.createElement("script");
1717
script.charset = "utf-8";
@@ -20,8 +20,8 @@ module.exports = function() {
2020
head.appendChild(script);
2121
}
2222

23+
// eslint-disable-next-line no-unused-vars
2324
function hotDownloadManifest(requestTimeout) {
24-
// eslint-disable-line no-unused-vars
2525
requestTimeout = requestTimeout || 10000;
2626
return new Promise(function(resolve, reject) {
2727
if (typeof XMLHttpRequest === "undefined")

‎lib/webworker/WebWorkerMainTemplate.runtime.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,19 @@
44
*/
55
/*globals installedChunks hotAddUpdateChunk parentHotUpdateCallback importScripts XMLHttpRequest $require$ $hotChunkFilename$ $hotMainFilename$ */
66
module.exports = function() {
7+
// eslint-disable-next-line no-unused-vars
78
function webpackHotUpdateCallback(chunkId, moreModules) {
8-
// eslint-disable-line no-unused-vars
99
hotAddUpdateChunk(chunkId, moreModules);
1010
if (parentHotUpdateCallback) parentHotUpdateCallback(chunkId, moreModules);
1111
} //$semicolon
1212

13+
// eslint-disable-next-line no-unused-vars
1314
function hotDownloadUpdateChunk(chunkId) {
14-
// eslint-disable-line no-unused-vars
1515
importScripts($require$.p + $hotChunkFilename$);
1616
}
1717

18+
// eslint-disable-next-line no-unused-vars
1819
function hotDownloadManifest(requestTimeout) {
19-
// eslint-disable-line no-unused-vars
2020
requestTimeout = requestTimeout || 10000;
2121
return new Promise(function(resolve, reject) {
2222
if (typeof XMLHttpRequest === "undefined")
@@ -57,8 +57,8 @@ module.exports = function() {
5757
});
5858
}
5959

60+
//eslint-disable-next-line no-unused-vars
6061
function hotDisposeChunk(chunkId) {
61-
//eslint-disable-line no-unused-vars
6262
delete installedChunks[chunkId];
6363
}
6464
};

‎test/BenchmarkTestCases.benchmark.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ describe("BenchmarkTestCases", function() {
2222

2323
try {
2424
fs.mkdirSync(path.join(__dirname, "js"));
25-
} catch (e) {}
25+
} catch (e) {} // eslint-disable-line no-empty
2626
try {
2727
fs.mkdirSync(baselinesPath);
28-
} catch (e) {}
28+
} catch (e) {} // eslint-disable-line no-empty
2929

3030
before(function(done) {
3131
this.timeout(270000);
@@ -43,7 +43,7 @@ describe("BenchmarkTestCases", function() {
4343
} else {
4444
try {
4545
fs.mkdirSync(baselinePath);
46-
} catch (e) {}
46+
} catch (e) {} // eslint-disable-line no-empty
4747
const gitIndex = path.resolve(rootPath, ".git/index");
4848
const index = fs.readFileSync(gitIndex);
4949
git(rootPath).raw(

‎test/ConfigTestCases.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ describe("ConfigTestCases", () => {
8787
testConfig,
8888
require(path.join(testDirectory, "test.config.js"))
8989
);
90-
} catch (e) {}
90+
} catch (e) {} // eslint-disable-line no-empty
9191

9292
this.timeout(testConfig.timeout);
9393

‎test/HotModuleReplacementPlugin.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ describe("HotModuleReplacementPlugin", function() {
2323
const recordsFile = path.join(__dirname, "js", "records.json");
2424
try {
2525
fs.mkdirSync(path.join(__dirname, "js"));
26-
} catch (e) {}
26+
} catch (e) {} // eslint-disable-line no-empty
2727
try {
2828
fs.unlinkSync(recordsFile);
29-
} catch (e) {}
29+
} catch (e) {} // eslint-disable-line no-empty
3030
const compiler = webpack({
3131
cache: false,
3232
entry: entryFile,

‎test/Parser.unittest.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -475,8 +475,10 @@ describe("Parser", () => {
475475
"wrapped=['str' string=str]+['four' string=four]",
476476
"'str'.concat(obj, 'one', 'two').concat('three', obj, 'four', 'five')":
477477
"wrapped=['str' string=str]+['four', 'five' string=fourfive]",
478+
// eslint-disable-next-line no-template-curly-in-string
478479
"`start${obj}mid${obj2}end`":
479-
"template=[start string=start],[mid string=mid],[end string=end]", // eslint-disable-line no-template-curly-in-string
480+
"template=[start string=start],[mid string=mid],[end string=end]",
481+
// eslint-disable-next-line no-template-curly-in-string
480482
"`start${'str'}mid${obj2}end`":
481483
"template=[start${'str'}mid string=startstrmid],[end string=end]", // eslint-disable-line no-template-curly-in-string
482484
"'abc'.substr(1)": "string=bc",

‎test/WatchDetection.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,21 +35,21 @@ describe("WatchDetection", () => {
3535
before(() => {
3636
try {
3737
fs.mkdirSync(fixturePath);
38-
} catch (e) {}
38+
} catch (e) {} // eslint-disable-line no-empty
3939
fs.writeFileSync(filePath, "require('./file2')", "utf-8");
4040
fs.writeFileSync(file2Path, "original", "utf-8");
4141
});
4242
after(done => {
4343
setTimeout(() => {
4444
try {
4545
fs.unlinkSync(filePath);
46-
} catch (e) {}
46+
} catch (e) {} // eslint-disable-line no-empty
4747
try {
4848
fs.unlinkSync(file2Path);
49-
} catch (e) {}
49+
} catch (e) {} // eslint-disable-line no-empty
5050
try {
5151
fs.rmdirSync(fixturePath);
52-
} catch (e) {}
52+
} catch (e) {} // eslint-disable-line no-empty
5353
done();
5454
}, 100); // cool down a bit
5555
});

‎test/WatchTestCases.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ describe("WatchTestCases", () => {
285285
testDirectory,
286286
"test.config.js"
287287
));
288-
} catch (e) {}
288+
} catch (e) {} // eslint-disable-line no-empty
289289

290290
if (testConfig.noTests) return process.nextTick(done);
291291
_require(

0 commit comments

Comments
 (0)