Escape module names

ooflorent · ooflorent · commit f9e7a1766647 · 2018-03-06T09:24:07.000+01:00
diff --git a/lib/node/NodeMainTemplatePlugin.js b/lib/node/NodeMainTemplatePlugin.js
@@ -29,7 +29,9 @@ module.exports = class NodeMainTemplatePlugin {
 						"// object to store loaded chunks",
 						'// "0" means "already loaded"',
 						"var installedChunks = {",
-						Template.indent(chunk.ids.map(id => `${id}: 0`).join(",\n")),
+						Template.indent(
+							chunk.ids.map(id => `${JSON.stringify(id)}: 0`).join(",\n")
+						),
 						"};"
 					]);
 				}
diff --git a/test/configCases/async-commons-chunk/node/index.js b/test/configCases/async-commons-chunk/node/index.js
@@ -0,0 +1,7 @@
+import "./modules/a";
+
+it("should load", done => {
+	Promise.all([import("./modules/b"), import("./modules/c")]).then(() => {
+		done();
+	});
+});
diff --git a/test/configCases/async-commons-chunk/node/modules/a.js b/test/configCases/async-commons-chunk/node/modules/a.js
@@ -0,0 +1,3 @@
+import "./b";
+
+export default "a";
diff --git a/test/configCases/async-commons-chunk/node/modules/b.js b/test/configCases/async-commons-chunk/node/modules/b.js
@@ -0,0 +1 @@
+export default "b";
diff --git a/test/configCases/async-commons-chunk/node/modules/c.js b/test/configCases/async-commons-chunk/node/modules/c.js
@@ -0,0 +1,3 @@
+import("./a");
+
+export default "c";
diff --git a/test/configCases/async-commons-chunk/node/webpack.config.js b/test/configCases/async-commons-chunk/node/webpack.config.js
@@ -0,0 +1,11 @@
+module.exports = {
+	mode: "none",
+	entry: {
+		"foo/bar": "./"
+	},
+	target: "node",
+	optimization: {
+		namedChunks: true,
+		namedModules: true
+	}
+};

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import "./b";`
	`2`	`+`
	`3`	`+export default "a";`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import("./a");`
	`2`	`+`
	`3`	`+export default "c";`