Skip to content

Commit 039d82f

Browse files
lemireDaniel Lemire
lemire
and
Daniel Lemire
authored
Returning basictests to its original function: basic tests (only) (simdjson#1010)
* The initial motivation behind basictests was for a quick set of sanity tests to check whether your code made sense. It was not meant for thorough testing to find corner cases. However, over time, it grew to include such expensive tests. This PR takes them out. It also allows us to bring back basictests to MinGW tests, since it is now cheap. This is not an exercise in software engineering and making things prettier. This is a pragmatic change to improve our test coverage and quality of life. * Adds many more cheap tests. Co-authored-by: Daniel Lemire <lemire@gmai.com>
1 parent a2f0933 commit 039d82f

File tree

6 files changed

+483
-395
lines changed

6 files changed

+483
-395
lines changed

‎.github/workflows/mingw-ci.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,5 @@ jobs:
5050
mkdir build32
5151
cd build32
5252
cmake -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_COMPETITION=OFF -DSIMDJSON_GOOGLE_BENCHMARKS=OFF -DSIMDJSON_ENABLE_THREADS=OFF ..
53-
cmake --build . --target basictests numberparsingcheck stringparsingcheck errortests integer_tests pointercheck --verbose
54-
ctest . -R stringparsingcheck --output-on-failure
55-
ctest . -R numberparsingcheck --output-on-failure
56-
ctest . -R errortests --output-on-failure
57-
ctest . -R integer_tests --output-on-failure
58-
ctest . -R pointercheck --output-on-failure
53+
cmake --build . --target parse_many_test jsoncheck basictests numberparsingcheck stringparsingcheck errortests integer_tests pointercheck --verbose
54+
ctest . -R "(parse_many_test|jsoncheck|basictests|stringparsingcheck|numberparsingcheck|errortests|integer_tests|pointercheck)" --output-on-failure

‎.github/workflows/mingw64-ci.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ jobs:
5151
mkdir build64
5252
cd build64
5353
cmake -DSIMDJSON_BUILD_STATIC=ON -DSIMDJSON_COMPETITION=OFF -DSIMDJSON_GOOGLE_BENCHMARKS=OFF -DSIMDJSON_ENABLE_THREADS=OFF ..
54-
cmake --build . --target basictests numberparsingcheck stringparsingcheck errortests integer_tests pointercheck --verbose
55-
ctest . -R stringparsingcheck --output-on-failure
56-
ctest . -R numberparsingcheck --output-on-failure
57-
ctest . -R errortests --output-on-failure
58-
ctest . -R integer_tests --output-on-failure
59-
ctest . -R pointercheck --output-on-failure
54+
cmake --build . --target parse_many_test jsoncheck basictests numberparsingcheck stringparsingcheck errortests integer_tests pointercheck --verbose
55+
ctest . -R "(parse_many_test|jsoncheck|basictests|stringparsingcheck|numberparsingcheck|errortests|integer_tests|pointercheck)" --output-on-failure
6056

‎tests/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ target_compile_definitions(stringparsingcheck PRIVATE NOMINMAX)
5252
# All remaining tests link with simdjson proper
5353
link_libraries(simdjson)
5454
add_cpp_test(basictests LABELS acceptance per_implementation)
55+
add_cpp_test(document_stream_tests LABELS acceptance per_implementation)
56+
add_cpp_test(document_tests LABELS acceptance per_implementation)
5557
add_cpp_test(errortests LABELS acceptance per_implementation)
5658
add_cpp_test(integer_tests LABELS acceptance per_implementation)
5759
add_cpp_test(jsoncheck LABELS acceptance per_implementation)

0 commit comments

Comments
 (0)