Fix for issue 1013.

Daniel Lemire · Daniel Lemire · commit 8764f42b78d8 · 2020-06-30T21:48:44.000-04:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -47,8 +47,9 @@ add_subdirectory(windows)
 if(NOT(SIMDJSON_JUST_LIBRARY))
   add_subdirectory(dependencies) ## This needs to be before tools because of cxxopts
   add_subdirectory(tools)  ## This needs to be before tests because of cxxopts
+  add_subdirectory(singleheader)
 endif()
-add_subdirectory(singleheader)
+install(FILES singleheader/simdjson.h DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
 
 #
 # Compile tools / tests / benchmarks
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -84,8 +84,16 @@ if(NOT MSVC)
   # Please do not delete the following, our users want version numbers. See
   # https://github.com/simdjson/simdjson/issues/1014
   # https://github.com/simdjson/simdjson/issues/52
-  ###########
-  set_target_properties(simdjson PROPERTIES VERSION ${SIMDJSON_LIB_VERSION}	SOVERSION ${SIMDJSON_LIB_SOVERSION})
+  ########### 
+  # We deliberately omit VERSION ${SIMDJSON_LIB_VERSION} since our version numbers do not follow
+  # the sonumber. The important point is that the soversion matches ABI compatibility. In simdjson
+  # version 0.2.0, 0.3.0 and 0.4.0 are not binary compatible. 
+  # 
+  # The soversion and the library version numbers are different numbers. It is common but
+  # not universal that the major version number is also the soversion number. However, there
+  # are notable exceptions. For example, glibc version 2.23 has a soversion of 6.
+  ############
+  set_target_properties(simdjson PROPERTIES SOVERSION ${SIMDJSON_LIB_SOVERSION})
   ##########
   # End of the do-not-delete message.
   #########
diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -180,14 +180,10 @@ endif()
 if(NOT MSVC)
   ######
   # This tests is to guard us against ever again removing the soversion
-  # and version numbers from the library. See Bug
+  # number from the library. See Bug
   # https://github.com/simdjson/simdjson/issues/1014
   #####
-  get_target_property(REPORTED_SIMDJSON_VERSION simdjson VERSION)
   get_target_property(REPORTED_SIMDJSON_SOVERSION simdjson SOVERSION)
-  if(NOT ${REPORTED_SIMDJSON_VERSION} STREQUAL ${SIMDJSON_LIB_VERSION})
-    message(FATAL_ERROR "The library target does not have the proper version information." )
-  endif()
   if(NOT ${REPORTED_SIMDJSON_SOVERSION} STREQUAL ${SIMDJSON_LIB_SOVERSION})
     message(FATAL_ERROR "The library target does not have the proper soversion information." )
   endif()
