Buffer overrun test

jkeiser · jkeiser · commit eb6c694ad5dc · 2020-05-28T14:08:15.000-07:00
diff --git a/src/generic/stage2/logger.h b/src/generic/stage2/logger.h
@@ -3,7 +3,7 @@
 namespace logger {
   static constexpr const char * DASHES = "----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------";
 
-  static constexpr const bool LOG_ENABLED = false;
+  static constexpr const bool LOG_ENABLED = true;
   static constexpr const int LOG_EVENT_LEN = 30;
   static constexpr const int LOG_BUFFER_LEN = 20;
   static constexpr const int LOG_DETAIL_LEN = 50;
@@ -55,7 +55,7 @@ namespace logger {
       }
       printf("|    %c ", printable_char(structurals.at_beginning() ? ' ' : structurals.current_char()));
       printf("|    %c ", printable_char(structurals.peek_char()));
-      printf("| %5zd ", structurals.next_structural);
+      printf("| %5zd ", structurals.next_structural, structurals.idx);
       printf("| %-*s ", LOG_DETAIL_LEN, detail);
       printf("|\n");
     }
diff --git a/tests/basictests.cpp b/tests/basictests.cpp
@@ -233,6 +233,14 @@ namespace document_tests {
     }
     return true;
   }
+  bool padded_with_open_bracket() {
+    std::cout << __func__ << std::endl;
+    simdjson::dom::parser parser;
+    // This is a valid document ([]), but it's padded with open braces.
+    auto error = parser.parse("[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[", 2, false).error();
+    if (error) { std::cerr << "Error: " << error << std::endl; return false; }
+    return true;
+  }
   // returns true if successful
   bool stable_test() {
     std::cout << __func__ << std::endl;
@@ -340,12 +348,15 @@ namespace document_tests {
     return true;
   }
   bool run() {
-    return bad_example() &&
-           count_array_example() &&
-           count_object_example() &&
-           stable_test() &&
-           skyprophet_test() &&
-           lots_of_brackets();
+    return true
+          //  && bad_example()
+          //  && count_array_example()
+          //  && count_object_example()
+           && padded_with_open_bracket()
+          //  && stable_test()
+          //  && skyprophet_test()
+          //  && lots_of_brackets()
+           ;
   }
 }
 
@@ -1934,13 +1945,14 @@ int main(int argc, char *argv[]) {
     printf("unsupported CPU\n");
   }
   std::cout << "Running basic tests." << std::endl;
-  if (parse_api_tests::run() &&
-      dom_api_tests::run() &&
-      type_tests::run() &&
-      format_tests::run() &&
-      document_tests::run() &&
-      number_tests::run() &&
-      document_stream_tests::run()
+  if (true
+      // && parse_api_tests::run()
+      // && dom_api_tests::run()
+      // && type_tests::run()
+      // && format_tests::run()
+      && document_tests::run()
+      // && number_tests::run()
+      // && document_stream_tests::run()
   ) {
     std::cout << "Basic tests are ok." << std::endl;
     return EXIT_SUCCESS;
