Faster case-insensitive comparisons. (simdjson#837)

lemire · web-flow · commit fc1ddcd2f839 · 2020-04-30T15:52:28.000-04:00
* Faster case-insensitive comparisons.
diff --git a/include/simdjson/document.h b/include/simdjson/document.h
@@ -313,6 +313,7 @@ class object : protected internal::tape_ref {
 
   /**
    * Get the value associated with the given key in a case-insensitive manner.
+   * It is only guaranteed to work over ASCII inputs.
    *
    * Note: The key will be matched against **unescaped** JSON.
    *
diff --git a/include/simdjson/inline/document.h b/include/simdjson/inline/document.h
@@ -686,10 +686,10 @@ inline simdjson_result<element> object::at_key_case_insensitive(const std::strin
   for (iterator field = begin(); field != end_field; ++field) {
     auto field_key = field.key();
     if (key.length() == field_key.length()) {
-      bool equal = true;
-      for (size_t i=0; i<field_key.length(); i++) {
-        equal = equal && std::tolower(key[i]) == std::tolower(field_key[i]);
-      }
+      // See For case-insensitive string comparisons, avoid char-by-char functions
+      // https://lemire.me/blog/2020/04/30/for-case-insensitive-string-comparisons-avoid-char-by-char-functions/
+      // Note that it might be worth rolling our own strncasecmp function, with vectorization.
+      const bool equal = (simdjson_strncasecmp(key.data(), field_key.data(), key.length()) == 0);
       if (equal) { return field.value(); }
     }
   }
diff --git a/include/simdjson/portability.h b/include/simdjson/portability.h
@@ -147,8 +147,13 @@ compiling for a known 64-bit platform."
 // regular visual studio and clang under visual studio.
 // clang under Windows has _stricmp (like visual studio) but not strcasecmp (as clang normally has)
 #define simdjson_strcasecmp _stricmp
+#define simdjson_strncasecmp _strnicmp
 #else
+// The strcasecmp, strncasecmp, and strcasestr functions do not work with multibyte strings (e.g. UTF-8).
+// So they are only useful for ASCII in our context.
+// https://www.gnu.org/software/libunistring/manual/libunistring.html#char-_002a-strings
 #define simdjson_strcasecmp strcasecmp
+#define simdjson_strncasecmp strncasecmp
 #endif
 
 namespace simdjson {

Original file line number	Diff line number	Diff line change
`@@ -313,6 +313,7 @@ class object : protected internal::tape_ref {`
`313`	`313`
`314`	`314`	`/**`
`315`	`315`	`* Get the value associated with the given key in a case-insensitive manner.`
	`316`	`+ * It is only guaranteed to work over ASCII inputs.`
`316`	`317`	`*`
`317`	`318`	`* Note: The key will be matched against unescaped JSON.`
`318`	`319`	`*`