Skip to content

Commit 2d4af95

Browse files
committed
Cache name of prefixed transform property
1 parent 71275b1 commit 2d4af95

File tree

3 files changed

+17
-13
lines changed

3 files changed

+17
-13
lines changed

jquery.stellar.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@
4848
setLeft: function($elem, val) { $elem.css('margin-left', val); }
4949
},
5050
transform: {
51-
getTop: function($elem) { return (getComputedStyle($elem[0])[vendorPrefix('transform')] !== 'none' ? parseInt(getComputedStyle($elem[0])[vendorPrefix('transform')].match(/(-?[0-9]+)/g)[5], 10) * -1 : 0); },
51+
getTop: function($elem) { return (getComputedStyle($elem[0])[transform] !== 'none' ? parseInt(getComputedStyle($elem[0])[transform].match(/(-?[0-9]+)/g)[5], 10) * -1 : 0); },
5252
setTop: function($elem, val) { setTransform($elem, val, 'Y'); },
5353

54-
getLeft: function($elem) { return (getComputedStyle($elem[0])[vendorPrefix('transform')] !== 'none' ? parseInt(getComputedStyle($elem[0])[vendorPrefix('transform')].match(/(-?[0-9]+)/g)[4], 10) * -1 : 0); },
54+
getLeft: function($elem) { return (getComputedStyle($elem[0])[transform] !== 'none' ? parseInt(getComputedStyle($elem[0])[transform].match(/(-?[0-9]+)/g)[4], 10) * -1 : 0); },
5555
setLeft: function($elem, val) { setTransform($elem, val, 'X'); }
5656
}
5757
},
@@ -63,7 +63,7 @@
6363
},
6464
transform: {
6565
setPosition: function($elem, left, startingLeft, top, startingTop) {
66-
$elem[0].style[vendorPrefix('transform')] = 'translate(' + ((left - startingLeft) || 0) + 'px, ' + ((top - startingTop) || 0) + 'px)';
66+
$elem[0].style[transform] = 'translate(' + ((left - startingLeft) || 0) + 'px, ' + ((top - startingTop) || 0) + 'px)';
6767
}
6868
}
6969
},
@@ -89,6 +89,8 @@
8989
};
9090
}()),
9191

92+
transform = vendorPrefix('transform'),
93+
9294
supportsBackgroundPositionXY = document.createElement('div').style.backgroundPositionX !== undefined,
9395

9496
setBackgroundPosition = (function() {
@@ -118,12 +120,12 @@
118120
}()),
119121

120122
setTransform = function($elem, val, dimension /* 'X' or 'Y' */) {
121-
var currentTransform = getComputedStyle($elem[0])[vendorPrefix('transform')];
123+
var currentTransform = getComputedStyle($elem[0])[transform];
122124

123125
if (currentTransform === 'none') {
124-
$elem[0].style[vendorPrefix('transform')] = 'translate' + dimension + '(' + val + 'px)';
126+
$elem[0].style[transform] = 'translate' + dimension + '(' + val + 'px)';
125127
} else {
126-
$elem[0].style[vendorPrefix('transform')] = replaceNthOccurence(currentTransform, /(-?[0-9]+[.]?[0-9]*)/g, (dimension === 'X' ? 5 : 6), val);
128+
$elem[0].style[transform] = replaceNthOccurence(currentTransform, /(-?[0-9]+[.]?[0-9]*)/g, (dimension === 'X' ? 5 : 6), val);
127129
}
128130
},
129131

0 commit comments

Comments
 (0)