Skip to content

Commit 0259b14

Browse files
committed
Deprecated EdgesHelper and WireframeHelper. See mrdoob#7533
1 parent 7b1a0a7 commit 0259b14

File tree

4 files changed

+16
-56
lines changed

4 files changed

+16
-56
lines changed

src/Three.Legacy.js

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,16 @@ import { EventDispatcher } from './core/EventDispatcher.js';
1212
import { Face3 } from './core/Face3.js';
1313
import { Object3D } from './core/Object3D.js';
1414
import { BoxGeometry } from './geometries/BoxGeometry.js';
15+
import { EdgesGeometry } from './geometries/EdgesGeometry.js';
1516
import { ExtrudeGeometry } from './geometries/ExtrudeGeometry.js';
1617
import { ShapeGeometry } from './geometries/ShapeGeometry.js';
18+
import { WireframeGeometry } from './geometries/WireframeGeometry.js';
1719
import { Light } from './lights/Light.js';
1820
import { AudioLoader } from './loaders/AudioLoader.js';
1921
import { CubeTextureLoader } from './loaders/CubeTextureLoader.js';
2022
import { TextureLoader } from './loaders/TextureLoader.js';
2123
import { Material } from './materials/Material.js';
24+
import { LineBasicMaterial } from './materials/LineBasicMaterial.js';
2225
import { MeshPhongMaterial } from './materials/MeshPhongMaterial.js';
2326
import { MultiMaterial } from './materials/MultiMaterial.js';
2427
import { PointsMaterial } from './materials/PointsMaterial.js';
@@ -33,6 +36,7 @@ import { Plane } from './math/Plane.js';
3336
import { Quaternion } from './math/Quaternion.js';
3437
import { Ray } from './math/Ray.js';
3538
import { Vector3 } from './math/Vector3.js';
39+
import { LineSegments } from './objects/LineSegments.js';
3640
import { LOD } from './objects/LOD.js';
3741
import { Points } from './objects/Points.js';
3842
import { Sprite } from './objects/Sprite.js';
@@ -88,6 +92,18 @@ export function Vertex ( x, y, z ) {
8892

8993
//
9094

95+
export function EdgesHelper( object, hex ) {
96+
console.warn( 'THREE.EdgesHelper has been removed. Use THREE.EdgesGeometry instead.' );
97+
return new LineSegments( new EdgesGeometry( object.geometry ), new LineBasicMaterial( { color: hex !== undefined ? hex : 0xffffff } ) );
98+
}
99+
100+
export function WireframeHelper( object, hex ) {
101+
console.warn( 'THREE.WireframeHelper has been removed. Use THREE.WireframeGeometry instead.' );
102+
return new LineSegments( new WireframeGeometry( object.geometry ), new LineBasicMaterial( { color: hex !== undefined ? hex : 0xffffff } ) );
103+
}
104+
105+
//
106+
91107
Object.assign( Box2.prototype, {
92108
center: function ( optionalTarget ) {
93109
console.warn( 'THREE.Box2: .center() has been renamed to .getCenter().' );

src/Three.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,15 +132,13 @@ export { Quaternion } from './math/Quaternion.js';
132132
export { ColorKeywords, Color } from './math/Color.js';
133133
export { MorphBlendMesh } from './extras/objects/MorphBlendMesh.js';
134134
export { ImmediateRenderObject } from './extras/objects/ImmediateRenderObject.js';
135-
export { WireframeHelper } from './extras/helpers/WireframeHelper.js';
136135
export { VertexNormalsHelper } from './extras/helpers/VertexNormalsHelper.js';
137136
export { SpotLightHelper } from './extras/helpers/SpotLightHelper.js';
138137
export { SkeletonHelper } from './extras/helpers/SkeletonHelper.js';
139138
export { PointLightHelper } from './extras/helpers/PointLightHelper.js';
140139
export { HemisphereLightHelper } from './extras/helpers/HemisphereLightHelper.js';
141140
export { GridHelper } from './extras/helpers/GridHelper.js';
142141
export { FaceNormalsHelper } from './extras/helpers/FaceNormalsHelper.js';
143-
export { EdgesHelper } from './extras/helpers/EdgesHelper.js';
144142
export { DirectionalLightHelper } from './extras/helpers/DirectionalLightHelper.js';
145143
export { CameraHelper } from './extras/helpers/CameraHelper.js';
146144
export { BoundingBoxHelper } from './extras/helpers/BoundingBoxHelper.js';

src/extras/helpers/EdgesHelper.js

Lines changed: 0 additions & 30 deletions
This file was deleted.

src/extras/helpers/WireframeHelper.js

Lines changed: 0 additions & 24 deletions
This file was deleted.

0 commit comments

Comments
 (0)