Skip to content

Commit 36c7a7b

Browse files
mrdoobmrdoob
committed
Removed statusDomElement.
1 parent e7f7d51 commit 36c7a7b

File tree

8 files changed

+177
-253
lines changed

8 files changed

+177
-253
lines changed

‎docs/api/loaders/Loader.html

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,6 @@ <h3>[method:String extractUrlBase]( [page:string url] )</h3>
6969
Extract the base from the URL.
7070
</div>
7171

72-
<h3>[method:DOMElement addStatusElement]()</h3>
73-
<div>
74-
Add a DOM element to indicate the progress and return the DOMElement
75-
</div>
76-
7772

7873
<h2>Source</h2>
7974

‎editor/js/libs/tern-threejs/threejs.js

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -2268,14 +2268,6 @@
22682268
"!type": "boolean",
22692269
"!doc": "If true, the ajax request will use cookies."
22702270
},
2271-
"showStatus": {
2272-
"!type": "bool",
2273-
"!doc": "If true, show loading status in the statusDomElement."
2274-
},
2275-
"statusDomElement": {
2276-
"!type": "DOMElement",
2277-
"!doc": "This is the recipient of status messages."
2278-
},
22792271
"onLoadStart": {
22802272
"!type": "function",
22812273
"!doc": "The default is a function with empty body."
@@ -2311,26 +2303,14 @@
23112303
"extractUrlBase": {
23122304
"!type": "fn(url: string) -> string",
23132305
"!doc": "Extract the base from the URL."
2314-
},
2315-
"addStatusElement": {
2316-
"!type": "fn() -> DOMElement",
2317-
"!doc": "Add a DOM element to indicate the progress and return the DOMElement"
23182306
}
23192307
},
23202308
"!doc": "A loader for loading objects in JSON format.",
2321-
"!type": "fn(showStatus: bool)"
2309+
"!type": "fn()"
23222310
},
23232311
"Loader": {
23242312
"!url": "http://threejs.org/docs/#Reference/loaders/Loader",
23252313
"prototype": {
2326-
"showStatus": {
2327-
"!type": "bool",
2328-
"!doc": "If true, show loading status in the statusDomElement."
2329-
},
2330-
"statusDomElement": {
2331-
"!type": "DOMElement",
2332-
"!doc": "This is the recipient of status messages."
2333-
},
23342314
"onLoadStart": {
23352315
"!type": "function",
23362316
"!doc": "The default is a function with empty body."
@@ -2362,14 +2342,10 @@
23622342
"extractUrlBase": {
23632343
"!type": "fn(url: string) -> string",
23642344
"!doc": "Extract the base from the URL."
2365-
},
2366-
"addStatusElement": {
2367-
"!type": "fn() -> DOMElement",
2368-
"!doc": "Add a DOM element to indicate the progress and return the DOMElement"
23692345
}
23702346
},
23712347
"!doc": "Base class for implementing loaders.",
2372-
"!type": "fn(showStatus: bool)"
2348+
"!type": "fn()"
23732349
},
23742350
"LoadingManager": {
23752351
"!url": "http://threejs.org/docs/#Reference/loaders/LoadingManager",

‎examples/js/loaders/BinaryLoader.js

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,6 @@ THREE.BinaryLoader.prototype = {
1919

2020
constructor: THREE.BinaryLoader,
2121

22-
// Deprecated
23-
24-
get statusDomElement () {
25-
26-
if ( this._statusDomElement === undefined ) {
27-
28-
this._statusDomElement = document.createElement( 'div' );
29-
30-
}
31-
32-
console.warn( 'THREE.BinaryLoader: .statusDomElement has been removed.' );
33-
return this._statusDomElement;
34-
35-
},
36-
3722
// Load models generated by slim OBJ converter with BINARY option (converter_obj_three_slim.py -t binary)
3823
// - binary models consist of two files: JS and BIN
3924
// - parameters

‎examples/js/loaders/FBXLoader.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616

1717
( function() {
1818

19-
THREE.FBXLoader = function ( showStatus, manager ) {
19+
THREE.FBXLoader = function ( manager ) {
2020

21-
THREE.Loader.call( this, showStatus );
21+
THREE.Loader.call( this );
2222
this.manager = ( manager !== undefined ) ? manager : THREE.DefaultLoadingManager;
2323
this.textureLoader = null;
2424
this.textureBasePath = null;

‎examples/js/loaders/MMDLoader.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@
3333
* - shadow support.
3434
*/
3535

36-
THREE.MMDLoader = function ( showStatus, manager ) {
36+
THREE.MMDLoader = function ( manager ) {
3737

38-
THREE.Loader.call( this, showStatus );
38+
THREE.Loader.call( this );
3939
this.manager = ( manager !== undefined ) ? manager : THREE.DefaultLoadingManager;
4040
this.defaultTexturePath = './models/default/';
4141

‎examples/js/loaders/ctm/CTMLoader.js

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -12,25 +12,6 @@ THREE.CTMLoader = function () {
1212

1313
THREE.Loader.call( this );
1414

15-
// Deprecated
16-
17-
Object.defineProperties( this, {
18-
statusDomElement: {
19-
get: function () {
20-
21-
if ( this._statusDomElement === undefined ) {
22-
23-
this._statusDomElement = document.createElement( 'div' );
24-
25-
}
26-
27-
console.warn( 'THREE.BinaryLoader: .statusDomElement has been removed.' );
28-
return this._statusDomElement;
29-
30-
}
31-
},
32-
} );
33-
3415
};
3516

3617
THREE.CTMLoader.prototype = Object.create( THREE.Loader.prototype );

0 commit comments

Comments
 (0)