WebGLRenderer: We need to clear depth even if we draw background. Maybe we can just clear depth...

mrdoob · mrdoob · commit 41500fe4d8a6 · 2016-06-14T18:27:59.000-07:00
diff --git a/src/renderers/WebGLRenderer.js b/src/renderers/WebGLRenderer.js
@@ -1160,14 +1160,25 @@ THREE.WebGLRenderer = function ( parameters ) {
 
 		//
 
-		var needsClear = this.autoClear || forceClear;
 		var background = scene.background;
 
 		if ( background === null ) {
 
 			glClearColor( _clearColor.r, _clearColor.g, _clearColor.b, _clearAlpha );
 
-		} else if ( background instanceof THREE.CubeTexture ) {
+		} else if ( background instanceof THREE.Color ) {
+
+			glClearColor( background.r, background.g, background.b, 1 );
+
+		}
+
+		if ( this.autoClear || forceClear ) {
+
+			this.clear( this.autoClearColor, this.autoClearDepth, this.autoClearStencil );
+
+		}
+
+		if ( background instanceof THREE.CubeTexture ) {
 
 			backgroundCamera2.projectionMatrix.copy( camera.projectionMatrix );
 
@@ -1179,28 +1190,12 @@ THREE.WebGLRenderer = function ( parameters ) {
 
 			_this.renderBufferDirect( backgroundCamera2, null, backgroundBoxMesh.geometry, backgroundBoxMesh.material, backgroundBoxMesh, null );
 
-			needsClear = false;
-
 		} else if ( background instanceof THREE.Texture ) {
 
 			backgroundPlaneMesh.material.map = background;
 
 			_this.renderBufferDirect( backgroundCamera, null, backgroundPlaneMesh.geometry, backgroundPlaneMesh.material, backgroundPlaneMesh, null );
 
-			needsClear = false;
-
-		} else if ( background instanceof THREE.Color ) {
-
-			glClearColor( background.r, background.g, background.b, 1 );
-
-			needsClear = true;
-
-		}
-
-		if ( needsClear ) {
-
-			this.clear( this.autoClearColor, this.autoClearDepth, this.autoClearStencil );
-
 		}
 
 		//
