Skip to content

Commit 85c4922

Browse files
committed
Respond to mrdoob's comments.
1 parent 1a6624d commit 85c4922

File tree

1 file changed

+13
-20
lines changed

1 file changed

+13
-20
lines changed

examples/js/effects/VREffect.js

Lines changed: 13 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
THREE.VREffect = function ( renderer, onError ) {
1313

1414
var vrHMD;
15-
var eyeTranslationL, eyeFOVL, rectL;
16-
var eyeTranslationR, eyeFOVR, rectR;
15+
var eyeTranslationL, eyeFOVL, renderRectL;
16+
var eyeTranslationR, eyeFOVR, renderRectR;
1717

1818
function gotVRDevices( devices ) {
1919

@@ -102,8 +102,8 @@ THREE.VREffect = function ( renderer, onError ) {
102102
eyeTranslationR = eyeParamsR.eyeTranslation;
103103
eyeFOVL = eyeParamsL.recommendedFieldOfView;
104104
eyeFOVR = eyeParamsR.recommendedFieldOfView;
105-
rectL = eyeParamsL.renderRect;
106-
rectR = eyeParamsR.renderRect;
105+
renderRectL = eyeParamsL.renderRect;
106+
renderRectR = eyeParamsR.renderRect;
107107

108108
if ( Array.isArray( scene ) ) {
109109

@@ -129,31 +129,24 @@ THREE.VREffect = function ( renderer, onError ) {
129129
cameraR.translateX( eyeTranslationR.x * this.scale );
130130

131131
// render left eye
132-
if ( rectL ) {
132+
if ( renderRectL === undefined ) {
133133

134-
renderer.setViewport( rectL.x, rectL.y, rectL.width, rectL.height );
135-
renderer.setScissor( rectL.x, rectL.y, rectL.width, rectL.height );
136-
137-
} else {
138-
139-
renderer.setViewport( 0, 0, size.width / 2, size.height );
140-
renderer.setScissor( 0, 0, size.width / 2, size.height );
134+
renderRectL = { x: 0, y: 0, width: size.width / 2, height: size.height };
141135

142136
}
137+
renderer.setViewport( renderRectL.x, renderRectL.y, renderRectL.width, renderRectL.height );
138+
renderer.setScissor( renderRectL.x, renderRectL.y, renderRectL.width, renderRectL.height );
143139
renderer.render( scene, cameraL );
144140

145141
// render right eye
146-
if ( rectR ) {
147-
148-
renderer.setViewport( rectR.x, rectR.y, rectR.width, rectR.height );
149-
renderer.setScissor( rectR.x, rectR.y, rectR.width, rectR.height );
142+
if ( renderRectR === undefined ) {
150143

151-
} else {
152-
153-
renderer.setViewport( size.width / 2, 0, size.width / 2, size.height );
154-
renderer.setScissor( size.width / 2, 0, size.width / 2, size.height );
144+
renderRectR = { x: size.width / 2, y: 0, width: size.width / 2, height: size.height };
155145

156146
}
147+
148+
renderer.setViewport( renderRectR.x, renderRectR.y, renderRectR.width, renderRectR.height );
149+
renderer.setScissor( renderRectR.x, renderRectR.y, renderRectR.width, renderRectR.height );
157150
renderer.render( scene, cameraR );
158151

159152
renderer.setScissorTest( false );

0 commit comments

Comments
 (0)