Faster projectOnVector function (mrdoob#9101)

loldrup · mrdoob · commit a1d4a3aeafb9 · 2016-06-08T14:41:10.000-07:00
This implementation of projectOnVector is faster and shorter than the current version, and it requires no intermediate Vector3 allocation
diff --git a/src/math/Vector3.js b/src/math/Vector3.js
@@ -594,23 +594,13 @@ THREE.Vector3.prototype = {
 
 	},
 
-	projectOnVector: function () {
+	projectOnVector: function ( vector ) {
 
-		var v1, dot;
-
-		return function projectOnVector( vector ) {
-
-			if ( v1 === undefined ) v1 = new THREE.Vector3();
-
-			v1.copy( vector ).normalize();
-
-			dot = this.dot( v1 );
-
-			return this.copy( v1 ).multiplyScalar( dot );
-
-		};
-
-	}(),
+		var scalar = vector.dot( this ) / vector.lengthSq();
+	
+		return this.copy( vector ).multiplyScalar( scalar );
+	
+	},
 
 	projectOnPlane: function () {
 
