Skip to content

Commit facbcd3

Browse files
committed
ShapeUtils: Simplified b2 and b3 methods.
1 parent dff36c0 commit facbcd3

File tree

1 file changed

+39
-31
lines changed

1 file changed

+39
-31
lines changed

src/extras/ShapeUtils.js

Lines changed: 39 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -494,64 +494,72 @@ THREE.ShapeUtils = {
494494

495495
// Quad Bezier Functions
496496

497-
b2p0: function ( t, p ) {
497+
b2: ( function () {
498498

499-
var k = 1 - t;
500-
return k * k * p;
499+
function b2p0( t, p ) {
501500

502-
},
501+
var k = 1 - t;
502+
return k * k * p;
503503

504-
b2p1: function ( t, p ) {
504+
}
505505

506-
return 2 * ( 1 - t ) * t * p;
506+
function b2p1( t, p ) {
507507

508-
},
508+
return 2 * ( 1 - t ) * t * p;
509509

510-
b2p2: function ( t, p ) {
510+
}
511511

512-
return t * t * p;
512+
function b2p2( t, p ) {
513513

514-
},
514+
return t * t * p;
515515

516-
b2: function ( t, p0, p1, p2 ) {
516+
}
517517

518-
return this.b2p0( t, p0 ) + this.b2p1( t, p1 ) + this.b2p2( t, p2 );
518+
return function ( t, p0, p1, p2 ) {
519519

520-
},
520+
return b2p0( t, p0 ) + b2p1( t, p1 ) + b2p2( t, p2 );
521+
522+
};
523+
524+
} )(),
521525

522526
// Cubic Bezier Functions
523527

524-
b3p0: function ( t, p ) {
528+
b3: ( function () {
525529

526-
var k = 1 - t;
527-
return k * k * k * p;
530+
function b3p0( t, p ) {
528531

529-
},
532+
var k = 1 - t;
533+
return k * k * k * p;
530534

531-
b3p1: function ( t, p ) {
535+
}
532536

533-
var k = 1 - t;
534-
return 3 * k * k * t * p;
537+
function b3p1( t, p ) {
535538

536-
},
539+
var k = 1 - t;
540+
return 3 * k * k * t * p;
537541

538-
b3p2: function ( t, p ) {
542+
}
539543

540-
var k = 1 - t;
541-
return 3 * k * t * t * p;
544+
function b3p2( t, p ) {
542545

543-
},
546+
var k = 1 - t;
547+
return 3 * k * t * t * p;
544548

545-
b3p3: function ( t, p ) {
549+
}
546550

547-
return t * t * t * p;
551+
function b3p3( t, p ) {
548552

549-
},
553+
return t * t * t * p;
554+
555+
}
556+
557+
return function ( t, p0, p1, p2, p3 ) {
550558

551-
b3: function ( t, p0, p1, p2, p3 ) {
559+
return b3p0( t, p0 ) + b3p1( t, p1 ) + b3p2( t, p2 ) + b3p3( t, p3 );
552560

553-
return this.b3p0( t, p0 ) + this.b3p1( t, p1 ) + this.b3p2( t, p2 ) + this.b3p3( t, p3 );
561+
};
554562

555-
}
563+
} )()
556564

557565
};

0 commit comments

Comments
 (0)