Vector*: Simplified setLength(). See mrdoob#7326.

mrdoob · mrdoob · commit fc881d66b4e7 · 2015-10-14T11:02:41.000-04:00
diff --git a/src/math/Vector2.js b/src/math/Vector2.js
@@ -379,15 +379,9 @@ THREE.Vector2.prototype = {
 
 	},
 
-	setLength: function ( l ) {
+	setLength: function ( length ) {
 
-		var oldLength = this.length();
-
-		if ( oldLength !== 0 && l !== oldLength ) {
-
-			this.multiplyScalar( l / oldLength );
-
-		}
+		this.multiplyScalar( length / this.length() );
 
 		return this;
 
diff --git a/src/math/Vector3.js b/src/math/Vector3.js
@@ -584,15 +584,9 @@ THREE.Vector3.prototype = {
 
 	},
 
-	setLength: function ( l ) {
+	setLength: function ( length ) {
 
-		var oldLength = this.length();
-
-		if ( oldLength !== 0 && l !== oldLength  ) {
-
-			this.multiplyScalar( l / oldLength );
-
-		}
+		this.multiplyScalar( length / this.length() );
 
 		return this;
 
@@ -701,7 +695,7 @@ THREE.Vector3.prototype = {
 
 	angleTo: function ( v ) {
 
-		var theta = this.dot( v ) / ( Math.sqrt( this.lengthSq() * v.lengthSq() ) );
+		var theta = this.dot( v ) / Math.sqrt( this.lengthSq() * v.lengthSq() );
 
 		// clamp, to handle numerical problems
 
diff --git a/src/math/Vector4.js b/src/math/Vector4.js
@@ -589,15 +589,9 @@ THREE.Vector4.prototype = {
 
 	},
 
-	setLength: function ( l ) {
+	setLength: function ( length ) {
 
-		var oldLength = this.length();
-
-		if ( oldLength !== 0 && l !== oldLength ) {
-
-			this.multiplyScalar( l / oldLength );
-
-		}
+		this.multiplyScalar( length / this.length() );
 
 		return this;
 
