fix(menu-button): make menu button title a component (videojs#5722)

chrisboustead · gkatsev · commit 2f0834f43f59 · 2019-01-18T14:56:58.000-05:00
Fixes videojs#3612, fixes videojs#5759
diff --git a/src/js/menu/menu-button.js b/src/js/menu/menu-button.js
@@ -108,16 +108,17 @@ class MenuButton extends Component {
 
     // Add a title list item to the top
     if (this.options_.title) {
-      const title = Dom.createEl('li', {
+      const titleEl = Dom.createEl('li', {
         className: 'vjs-menu-title',
         innerHTML: toTitleCase(this.options_.title),
         tabIndex: -1
       });
 
       this.hideThreshold_ += 1;
 
-      menu.children_.unshift(title);
-      Dom.prependTo(title, menu.contentEl());
+      const titleComponent = new Component(this.player_, {el: titleEl});
+
+      menu.addItem(titleComponent);
     }
 
     this.items = this.createItems();
