test: fix travis ci issues with resize-manager tests (videojs#5390)

brandonocasey · web-flow · commit 3744df168009 · 2018-08-28T16:24:26.000-04:00
diff --git a/src/js/resize-manager.js b/src/js/resize-manager.js
@@ -59,21 +59,22 @@ class ResizeManager extends Component {
     this.resizeObserver_ = null;
     this.debouncedHandler_ = debounce(() => {
       this.resizeHandler();
-    }, 100, false, player);
+    }, 100, false, this);
 
     if (RESIZE_OBSERVER_AVAILABLE) {
       this.resizeObserver_ = new this.ResizeObserver(this.debouncedHandler_);
       this.resizeObserver_.observe(player.el());
 
     } else {
       this.loadListener_ = () => {
-        if (this.el_.contentWindow) {
-          Events.on(this.el_.contentWindow, 'resize', this.debouncedHandler_);
+        if (!this.el_ || this.el_.contentWindow) {
+          return;
         }
-        this.off('load', this.loadListener_);
+
+        Events.on(this.el_.contentWindow, 'resize', this.debouncedHandler_);
       };
 
-      this.on('load', this.loadListener_);
+      this.one('load', this.loadListener_);
     }
   }
 
@@ -95,10 +96,20 @@ class ResizeManager extends Component {
      * @event Player#playerresize
      * @type {EventTarget~Event}
      */
+    // make sure player is still around to trigger
+    // prevents this from causing an error after dispose
+    if (!this.player_ || !this.player_.trigger) {
+      return;
+    }
+
     this.player_.trigger('playerresize');
   }
 
   dispose() {
+    if (this.debouncedHandler_) {
+      this.debouncedHandler_.cancel();
+    }
+
     if (this.resizeObserver_) {
       if (this.player_.el()) {
         this.resizeObserver_.unobserve(this.player_.el());
@@ -114,15 +125,10 @@ class ResizeManager extends Component {
       this.off('load', this.loadListener_);
     }
 
-    if (this.debouncedHandler_) {
-      this.debouncedHandler_.cancel();
-    }
-
     this.ResizeObserver = null;
     this.resizeObserver = null;
     this.debouncedHandler_ = null;
     this.loadListener_ = null;
-    super.dispose();
   }
 
 }
