fix: call component dispose in resize manager to fix leak (videojs#5369)

brandonocasey · gkatsev · commit 6f072d8e2f7e · 2018-08-10T16:21:13.000-04:00
Because we add Touch Activity in the parent class and those don't actually get removed in Resize Manager we leak on every dispose. Calling super.dispose() cleans them up because we remove our list of handlers via a call to DomData.removeData Fixes videojs#5339
diff --git a/src/js/resize-manager.js b/src/js/resize-manager.js
@@ -47,7 +47,10 @@ class ResizeManager extends Component {
     }
 
     // Only create an element when ResizeObserver isn't available
-    const options_ = mergeOptions({createEl: !RESIZE_OBSERVER_AVAILABLE}, options);
+    const options_ = mergeOptions({
+      createEl: !RESIZE_OBSERVER_AVAILABLE,
+      reportTouchActivity: false
+    }, options);
 
     super(player, options_);
 
@@ -115,6 +118,7 @@ class ResizeManager extends Component {
     this.resizeObserver = null;
     this.debouncedHandler_ = null;
     this.loadListener_ = null;
+    super.dispose();
   }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,10 @@ class ResizeManager extends Component {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`// Only create an element when ResizeObserver isn't available`
`50`		`- const options_ = mergeOptions({createEl: !RESIZE_OBSERVER_AVAILABLE}, options);`
	`50`	`+ const options_ = mergeOptions({`
	`51`	`+ createEl: !RESIZE_OBSERVER_AVAILABLE,`
	`52`	`+ reportTouchActivity: false`
	`53`	`+ }, options);`
`51`	`54`
`52`	`55`	`super(player, options_);`
`53`	`56`
`@@ -115,6 +118,7 @@ class ResizeManager extends Component {`
`115`	`118`	`this.resizeObserver = null;`
`116`	`119`	`this.debouncedHandler_ = null;`
`117`	`120`	`this.loadListener_ = null;`
	`121`	`+ super.dispose();`
`118`	`122`	`}`
`119`	`123`
`120`	`124`	`}`