fix: silence play promise in a few more places (videojs#5213)

rtezera1 · gkatsev · commit a29156ca7b77 · 2018-06-04T15:25:51.000-04:00
Silence the play promise in the Big Play Button, click-to-play, and the poster image.
diff --git a/src/js/big-play-button.js b/src/js/big-play-button.js
@@ -3,7 +3,7 @@
  */
 import Button from './button.js';
 import Component from './component.js';
-import {isPromise} from './utils/promise';
+import {isPromise, silencePromise} from './utils/promise';
 
 /**
  * The initial play button that shows before the video has played. The hiding of the
@@ -46,6 +46,7 @@ class BigPlayButton extends Button {
 
     // exit early if clicked via the mouse
     if (this.mouseused_ && event.clientX && event.clientY) {
+      silencePromise(playPromise);
       return;
     }
 
diff --git a/src/js/player.js b/src/js/player.js
@@ -1637,7 +1637,7 @@ class Player extends Component {
     }
 
     if (this.paused()) {
-      this.play();
+      silencePromise(this.play());
     } else {
       this.pause();
     }
diff --git a/src/js/poster-image.js b/src/js/poster-image.js
@@ -5,6 +5,7 @@ import ClickableComponent from './clickable-component.js';
 import Component from './component.js';
 import * as Fn from './utils/fn.js';
 import * as Dom from './utils/dom.js';
+import {silencePromise} from './utils/promise';
 
 /**
  * A `ClickableComponent` that handles showing the poster image for the player.
@@ -112,7 +113,7 @@ class PosterImage extends ClickableComponent {
     }
 
     if (this.player_.paused()) {
-      this.player_.play();
+      silencePromise(this.player_.play());
     } else {
       this.player_.pause();
     }

Original file line number	Diff line number	Diff line change
`@@ -1637,7 +1637,7 @@ class Player extends Component {`
`1637`	`1637`	`}`
`1638`	`1638`
`1639`	`1639`	`if (this.paused()) {`
`1640`		`- this.play();`
	`1640`	`+ silencePromise(this.play());`
`1641`	`1641`	`} else {`
`1642`	`1642`	`this.pause();`
`1643`	`1643`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ import ClickableComponent from './clickable-component.js';`
`5`	`5`	`import Component from './component.js';`
`6`	`6`	`import * as Fn from './utils/fn.js';`
`7`	`7`	`import * as Dom from './utils/dom.js';`
	`8`	`+import {silencePromise} from './utils/promise';`
`8`	`9`
`9`	`10`	`/**`
`10`	`11`	* A `ClickableComponent` that handles showing the poster image for the player.
`@@ -112,7 +113,7 @@ class PosterImage extends ClickableComponent {`
`112`	`113`	`}`
`113`	`114`
`114`	`115`	`if (this.player_.paused()) {`
`115`		`- this.player_.play();`
	`116`	`+ silencePromise(this.player_.play());`
`116`	`117`	`} else {`
`117`	`118`	`this.player_.pause();`
`118`	`119`	`}`