test: check unexpected warnings

yyx990803 · yyx990803 · commit 00c137fb2787 · 2016-11-24T11:50:20.000-05:00
diff --git a/test/helpers/to-have-been-warned.js b/test/helpers/to-have-been-warned.js
@@ -5,6 +5,7 @@ if (typeof console === 'undefined') {
   }
 }
 
+let asserted
 function hasWarned (msg) {
   var count = console.error.calls.count()
   var args
@@ -23,11 +24,13 @@ function hasWarned (msg) {
 
 // define custom matcher for warnings
 beforeEach(() => {
+  asserted = []
   spyOn(console, 'error')
   jasmine.addMatchers({
     toHaveBeenWarned: () => {
       return {
         compare: msg => {
+          asserted = asserted.concat(msg)
           var warned = Array.isArray(msg)
             ? msg.some(hasWarned)
             : hasWarned(msg)
@@ -42,3 +45,17 @@ beforeEach(() => {
     }
   })
 })
+
+afterEach(done => {
+  const warned = msg => asserted.some(assertedMsg => msg.indexOf(assertedMsg) > -1)
+  let count = console.error.calls.count()
+  let args
+  while (count--) {
+    args = console.error.calls.argsFor(count)
+    if (!warned(args[0])) {
+      done.fail(`Unexpected console.error message: ${args[0]}`)
+      return
+    }
+  }
+  done()
+})
diff --git a/test/helpers/wait-for-update.js b/test/helpers/wait-for-update.js
@@ -40,7 +40,7 @@ window.waitForUpdate = initialCb => {
 
   Vue.nextTick(() => {
     if (!queue.length || !queue[queue.length - 1].fail) {
-      console.warn('waitForUpdate chain is missing .then(done)')
+      throw new Error('waitForUpdate chain is missing .then(done)')
     }
     shift()
   })

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ window.waitForUpdate = initialCb => {`
`40`	`40`
`41`	`41`	`Vue.nextTick(() => {`
`42`	`42`	`if (!queue.length \|\| !queue[queue.length - 1].fail) {`
`43`		`- console.warn('waitForUpdate chain is missing .then(done)')`
	`43`	`+ throw new Error('waitForUpdate chain is missing .then(done)')`
`44`	`44`	`}`
`45`	`45`	`shift()`
`46`	`46`	`})`