remove parent/ref elm references when destroying instance, fix memory leak (fix vue-router#1279)

yyx990803 · yyx990803 · commit 3209f6f517a4 · 2017-03-27T09:49:05.000+08:00
diff --git a/src/core/instance/lifecycle.js b/src/core/instance/lifecycle.js
@@ -119,15 +119,18 @@ export function lifecycleMixin (Vue: Class<Component>) {
     }
     // call the last hook...
     vm._isDestroyed = true
+    // invoke destroy hooks on current rendered tree
+    vm.__patch__(vm._vnode, null)
+    // fire destroyed hook
     callHook(vm, 'destroyed')
     // turn off all instance listeners.
     vm.$off()
     // remove __vue__ reference
     if (vm.$el) {
       vm.$el.__vue__ = null
     }
-    // invoke destroy hooks on current rendered tree
-    vm.__patch__(vm._vnode, null)
+    // remove reference to DOM nodes (prevents leak)
+    vm.$options._parentElm = vm.$options._refElm = null
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -119,15 +119,18 @@ export function lifecycleMixin (Vue: Class<Component>) {`
`119`	`119`	`}`
`120`	`120`	`// call the last hook...`
`121`	`121`	`vm._isDestroyed = true`
	`122`	`+ // invoke destroy hooks on current rendered tree`
	`123`	`+ vm.__patch__(vm._vnode, null)`
	`124`	`+ // fire destroyed hook`
`122`	`125`	`callHook(vm, 'destroyed')`
`123`	`126`	`// turn off all instance listeners.`
`124`	`127`	`vm.$off()`
`125`	`128`	`// remove __vue__ reference`
`126`	`129`	`if (vm.$el) {`
`127`	`130`	`vm.$el.__vue__ = null`
`128`	`131`	`}`
`129`		`- // invoke destroy hooks on current rendered tree`
`130`		`- vm.__patch__(vm._vnode, null)`
	`132`	`+ // remove reference to DOM nodes (prevents leak)`
	`133`	`+ vm.$options._parentElm = vm.$options._refElm = null`
`131`	`134`	`}`
`132`	`135`	`}`
`133`	`136`