warn v-repeat filters that do not return Arrays

yyx990803 · yyx990803 · commit 39d978d948ad · 2015-09-07T15:48:55.000-04:00
diff --git a/src/directives/repeat.js b/src/directives/repeat.js
@@ -192,6 +192,12 @@ module.exports = {
    */
 
   update: function (data) {
+    if (process.env.NODE_ENV !== 'production' && !_.isArray(data)) {
+      _.warn(
+        'v-repeat pre-converts Objects into Arrays, and ' +
+        'v-repeat filters should always return Arrays.'
+      )
+    }
     if (this.componentId) {
       var state = this.componentState
       if (state === UNRESOLVED) {
diff --git a/test/unit/specs/directives/repeat_spec.js b/test/unit/specs/directives/repeat_spec.js
@@ -802,6 +802,22 @@ if (_.inBrowser) {
       })
     })
 
+    it('warn filters that return non-Array values', function () {
+      new Vue({
+        el: el,
+        template: '<div v-repeat="items | test"></div>',
+        data: {
+          items: []
+        },
+        filters: {
+          test: function (val) {
+            return {}
+          }
+        }
+      })
+      expect(hasWarned(_, 'should always return Arrays')).toBe(true)
+    })
+
   })
 }
 
